GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Adding tests for PSDiagnostics Module by kvprasoon · Pull Request #8431 · PowerShell/PowerShell

Conversation

@kvprasoon

@kvprasoon PRASOON KARUNAN V (kvprasoon) commented Dec 9, 2018 •
edited by iSazonov
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Close #8367.

Adding tests for PSDiagnostics Module.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link: Add tests for PSDiagnostics cmdlets #8367
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
PRASOON KARUNAN V (kvprasoon) added 3 commits December 9, 2018 22:07
@kvprasoon
Adding testes for PSDiagnostics Module as per PowerShell#8367
5437345
@kvprasoon
Added missing Skip switch for a test
981e929
@kvprasoon
Check if Windows in BeforeEah block.
7b435eb
@kvprasoon PRASOON KARUNAN V (kvprasoon) changed the title Adding testes for PSDiagnostics Module as per #8367 Adding tests for PSDiagnostics Module as per #8367 Dec 9, 2018
vexx32
Rain Sallow (/u/ta11ow) (vexx32) reviewed Dec 9, 2018
View reviewed changes
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
vexx32
Rain Sallow (/u/ta11ow) (vexx32) reviewed Dec 9, 2018
View reviewed changes
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
vexx32
Rain Sallow (/u/ta11ow) (vexx32) reviewed Dec 9, 2018
View reviewed changes
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
vexx32
Rain Sallow (/u/ta11ow) (vexx32) reviewed Dec 9, 2018
View reviewed changes
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
vexx32
Rain Sallow (/u/ta11ow) (vexx32) reviewed Dec 9, 2018
View reviewed changes
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
PRASOON KARUNAN V (kvprasoon) added 2 commits December 10, 2018 07:35
@kvprasoon
changes as per review comments
fe68ac4
@kvprasoon
Bool convertion changes as per review comment.
f67007b
iSazonov
Ilya (iSazonov) reviewed Dec 10, 2018
View reviewed changes
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kvprasoon
Changes as per review comments for skipping test cases
8013fa8
vexx32
Rain Sallow (/u/ta11ow) (vexx32) reviewed Dec 10, 2018
View reviewed changes
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kvprasoon
removing -Name parameter usages
770cb94
iSazonov
Ilya (iSazonov) reviewed Dec 10, 2018
View reviewed changes
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
PRASOON KARUNAN V (kvprasoon) added 3 commits December 10, 2018 23:51
@kvprasoon
Changes as per review comments
331112d
@kvprasoon
Adding periods.
d24d4a3
@kvprasoon
Adding check for resetting log settings
90d8702
iSazonov
Ilya (iSazonov) approved these changes Dec 11, 2018
View reviewed changes
@stale

stale Bot commented Jan 10, 2019

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot added the Stale label Jan 10, 2019
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Travis Plunk (TravisEz13) Jan 11, 2019
@stale stale Bot removed the Stale label Jan 11, 2019
@iSazonov Ilya (iSazonov) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 11, 2019
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title Adding tests for PSDiagnostics Module as per #8367 Adding tests for PSDiagnostics Module Jan 14, 2019
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Jan 14, 2019
View reviewed changes
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
PRASOON KARUNAN V (kvprasoon) added 2 commits January 14, 2019 23:57
@kvprasoon
Merge branch 'master' into psd-tests
5c9d194
@kvprasoon
Review comment fixes
d511d0e
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Jan 14, 2019
View reviewed changes
Comment thread test/powershell/Modules/PSDiagnostics/PSDiagnostics.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kvprasoon
remove hardcode
3f61287
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jan 15, 2019
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Jan 16, 2019

Copy link
Copy Markdown
Collaborator

Travis Plunk (@TravisEz13) Please merge the PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) merged commit 6b3e068 into PowerShell:master Jan 16, 2019
@kvprasoon
PRASOON KARUNAN V (kvprasoon) deleted the psd-tests branch January 17, 2019 06:44
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@kvprasoon @TravisEz13
Adding tests for PSDiagnostics Module (PowerShell#8431)
f8ea952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
+1 more reviewer
@vexx32 Rain Sallow (/u/ta11ow) (vexx32) vexx32 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add tests for PSDiagnostics cmdlets

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@kvprasoon @iSazonov @adityapatwardhan @vexx32 @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.