GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add gitkracken files to gitignore by RDIL · Pull Request #8434 · PowerShell/PowerShell

Conversation

@RDIL

@RDIL Reece Dunham (RDIL) commented Dec 10, 2018 •
edited by iSazonov
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

GitKracken is a pretty popular git client so let’s ignore useless files it makes

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RDIL
Add gitkracken files to gitignore
0207a3f
@RDIL

Reece Dunham (RDIL) commented Dec 10, 2018

Copy link
Copy Markdown
Contributor Author

Sorry don’t know why the rest isn’t rendering, meant to say it’s a popular git client and those files shouldn’t be committed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov
Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Travis Plunk (TravisEz13) December 10, 2018 16:35
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Dec 10, 2018
@iSazonov Ilya (iSazonov) added the CL-Untagged label Dec 10, 2018
TravisEz13
Travis Plunk (TravisEz13) approved these changes Dec 10, 2018
View reviewed changes
@TravisEz13 Travis Plunk (TravisEz13) added CL-Tools Indicates that a PR should be marked as a tools change in the Change Log and removed CL-Untagged labels Dec 10, 2018
@ghost

Deleted user (ghost) commented Dec 12, 2018

Copy link
Copy Markdown

Reece Dunham (@RDIL) Not gkconfg.yml but gkconfig.yml
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Dec 12, 2018 via email

Copy link
Copy Markdown
Contributor Author
Sorry!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RDIL
Fix my typo
768770b
@TravisEz13
Travis Plunk (TravisEz13) merged commit 0514d83 into PowerShell:master Dec 12, 2018
@TravisEz13

Travis Plunk (TravisEz13) commented Dec 12, 2018

Copy link
Copy Markdown
Member

Thank you @PSVortex for you contribution and Reece Dunham (@RDIL) for your review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Dec 12, 2018 via email

Copy link
Copy Markdown
Contributor Author
other way round xD
TravisEz13 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Dec 12, 2018

Copy link
Copy Markdown
Member

Sorry...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Dec 12, 2018 via email

Copy link
Copy Markdown
Contributor Author
Haha it’s fine
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL
Reece Dunham (RDIL) deleted the patch-1 branch January 17, 2019 15:46
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@RDIL @TravisEz13
Add gitkracken files to gitignore (PowerShell#8434)
21a8255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@RDIL @TravisEz13 @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.