GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — support for linuxmint in installpsh-debian.sh by DarwinJS · Pull Request #8440 · PowerShell/PowerShell

Conversation

@DarwinJS

@DarwinJS Darwin (DarwinJS) commented Dec 11, 2018

Copy link
Copy Markdown
Contributor

PR Summary

Add #8437 - add linuxmint support

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
  • Testing - New and feature
    • Not Applicable or can only be tested interactively

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DarwinJS
installpsh-debian.sh support for linuxmint
ffbd3ad
@DarwinJS
Darwin (DarwinJS) requested review from Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners December 11, 2018 01:23
@DarwinJS

Darwin (DarwinJS) commented Dec 11, 2018

Copy link
Copy Markdown
Contributor Author

There is an official docker image (https://hub.docker.com/r/linuxmintd/mint19-amd64/), but do you bother with doing tests only for install scripts?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Dec 11, 2018
@TravisEz13

Travis Plunk (TravisEz13) commented Dec 11, 2018

Copy link
Copy Markdown
Member

I ran the install-ps CI here and set it to automatically run in the future: https://powershell.visualstudio.com/PowerShell/_build/results?buildId=7894
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Dec 11, 2018
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 5478cf6 into PowerShell:master Dec 11, 2018
@TravisEz13 Travis Plunk (TravisEz13) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Dec 11, 2018
@DarwinJS

Darwin (DarwinJS) commented Dec 11, 2018

Copy link
Copy Markdown
Contributor Author

Wow that was fast - thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Dec 12, 2018

Copy link
Copy Markdown
Member

Darwin (@DarwinJS) It's a lot easier to be confident that it works with a CI system in place.

Thanks for keeping these up to date.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DarwinJS
Darwin (DarwinJS) deleted the issue-8437-installpsh-debian-support-for-linuxmint branch December 12, 2018 03:02
@DarwinJS

Darwin (DarwinJS) commented Dec 12, 2018

Copy link
Copy Markdown
Contributor Author

LinuxMint is worth it - finally a distro that does not annoy the daylights out of all my windows keyboard shortcut reflexes :)
TravisEz13 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Dec 12, 2018

Copy link
Copy Markdown
Member

I like LinuxMint too, but I found macOS has the apps I need to run it full time.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DarwinJS

Darwin (DarwinJS) commented Dec 12, 2018

Copy link
Copy Markdown
Contributor Author

Yes - I don't use it as a primary - but for testing bash and powershell core since the rest of my team runs macs. Although I am doing more of that with Docker as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Dec 13, 2018

Copy link
Copy Markdown
Member

I started using https://github.com/CanonicalLtd/multipass for a lot of my testing of Linux from macOS. This is partly because I'm testing snap packages which don't really work in docker.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@DarwinJS @TravisEz13
support for linuxmint in installpsh-debian.sh (PowerShell#8440)
746e82f 
Add PowerShell#8437 - add linuxmint support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DarwinJS @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.