GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Join-String cmdlet FormatString parameter logic by sethvs · Pull Request #8449 · PowerShell/PowerShell

Conversation

@sethvs

@sethvs Sergey Vasin (sethvs) commented Dec 11, 2018

Copy link
Copy Markdown
Contributor

PR Summary

Fix #8448
PR changes logic when applying FormatString parameter value.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sethvs
Fix FormatString logic
ff32daa
@sethvs
Sergey Vasin (sethvs) requested review from James Truher (JamesWTruher) and Paul Higinbotham (PaulHigin) as code owners December 11, 2018 16:50
@iSazonov

Ilya (iSazonov) commented Dec 11, 2018

Copy link
Copy Markdown
Collaborator

Sergey Vasin (@sethvs) Please add tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 11, 2018
@sethvs
Add test.
c10a6b0
@sethvs

Sergey Vasin (sethvs) commented Dec 12, 2018

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Done.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@PaulHigin

Paul Higinbotham (PaulHigin) commented Dec 12, 2018

Copy link
Copy Markdown
Contributor

Looking...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Dec 12, 2018
View reviewed changes

@PaulHigin Paul Higinbotham (PaulHigin) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sethvs

Sergey Vasin (sethvs) commented Jan 9, 2019

Copy link
Copy Markdown
Contributor Author

Close and reopen to re-trigger hung license/cla check.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sethvs Sergey Vasin (sethvs) closed this Jan 9, 2019
@sethvs Sergey Vasin (sethvs) reopened this Jan 9, 2019
@iSazonov Ilya (iSazonov) self-assigned this Jan 9, 2019
@iSazonov
Ilya (iSazonov) merged commit 6f071f0 into PowerShell:master Jan 9, 2019
@sethvs
Sergey Vasin (sethvs) deleted the joinString branch January 9, 2019 06:21
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@sethvs @iSazonov
Fix Join-String cmdlet FormatString parameter logic (PowerShell#8449)
9d11c7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
1 more reviewer
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Join-String -FormatString parameter doesn't apply properly

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sethvs @iSazonov @PaulHigin @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.