GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||
GeezerVison is showing github.com — Add fix for nested (Debug-Runspace) debugging on non-Windows platforms and re-enable Windows identity impersonation flow by PaulHigin · Pull Request #8451 · PowerShell/PowerShell Conversation
Contributor
PR SummaryNested runspace debugging is now supported on non-Windows platforms after Enter-PSHostProcess was added. However, nested debugging was broken because the Windows impersonation code portion was not fully ifdefed out. This change removes Windows only impersonation code for cross platform builds. It also updates the Windows impersonation flow code to work with dotNet Core. Repro: # On one PowerShell shell instance run: $pid 14931 $ps = [powershell]::Create() $ps.AddScript('1..20 | % { sleep 1; "Output $_" }').Invoke() # On second PowerShell shell run: Enter-PSHostProcess -Id 14931 [Process:14931]: PS > Debug-Runspace -Id 2 Expect: Should be able to run a nested debug session on script. Result: Cannot debug script due to "Unsupported platform error". PR Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Paul Higinbotham (PaulHigin)
requested a review
from Travis Plunk (TravisEz13)
Paul Higinbotham (PaulHigin)
requested a review
from Mike Richmond (mirichmo)
as a code owner
Paul Higinbotham (PaulHigin)
removed the request for review
from Mike Richmond (mirichmo)
Travis Plunk (TravisEz13)
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Travis Plunk (@TravisEz13) Paul Higinbotham (@PaulHigin) We ran into an issue before with
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. …t RunImpersonated.
Paul Higinbotham (PaulHigin)
requested a review
from Bruce Payette (BrucePay)
as a code owner
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
Dongbo Wang (daxian-dbw)
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
…dentity impersonation code (PowerShell#8451)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesLabels
CL-Engine
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |