GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — Add support to show suggestions on CommandNotFound exception by SteveL-MSFT · Pull Request #8458 · PowerShell/PowerShell Conversation
|
|
We could consider other names of the parameter: -Fuzzy, -FuzzyMatching, -ShowSuggestions, -Suggestions. We need PowerShell Committee approvement for the new public API. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
We could introduce a test hook to do something like write output to the information stream or to a variable for testing purposes for now |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Rob Holt (@rjmholt) I suggest we defer the test hook as that would make sense for testing suggestions in general and not this specific change. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It was good to have a tracking issue if we needed these special tests. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ilya (@iSazonov) created #8486 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Steve Lee (@SteveL-MSFT) Do you want to wait on Rob to review your changes? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Travis Plunk (@TravisEz13) if Rob Holt (@rjmholt) has further comments, we can treat it as a separate issue and PR. Would like to get this in for next Preview |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It would be good to fix some style issues and "s_" before merge. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@PowerShell/powershell-committee reviewed this and is ok with |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…eful in finding close matches
removed use of Tuple and created struct
1d51a6d to
580911b
Compare
…ell#8458) * support fuzzy matching with get-command and on CommandNotFound exception, show suggestion * fix CodeFactor issues * change algorithm to use Damerau-Levenshtein Distance which is more useful in finding close matches
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.