GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update examples for hosting PSCore and remove old outdated examples before 6.0.0 RTM by bergmeister · Pull Request #8472 · PowerShell/PowerShell

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Dec 16, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Update project and NuGet packages to netcoreapp2.1 and 6.1.1 NuGet packages, old projects before 6.0 RTM time are being removed.
I checked it works by running dotnet run on the project.
cc Keith Hill (@rkeithhill)

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister (bergmeister) added 2 commits December 16, 2018 14:53
@bergmeister
Update examples with newer version of .Net Core and NuGet APIs. Delet…
d5f743a 
…e .Net Core 2.2 example and update APIs being called
@bergmeister
rename and update readme and delete old versions
b28a356
@bergmeister
Christoph Bergmeister (bergmeister) requested review from Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners December 16, 2018 15:42
Christoph Bergmeister (bergmeister) added 3 commits December 16, 2018 15:45
@bergmeister
try fix spelling
b3ad71f
@bergmeister
try fix spelling again
6ee1cb5
@bergmeister
add crossplatform to .spelling
5112365
iSazonov
Ilya (iSazonov) reviewed Dec 16, 2018
View reviewed changes
Comment thread docs/host-powershell/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread docs/host-powershell/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) assigned Dongbo Wang (daxian-dbw) Dec 16, 2018
daxian-dbw
Dongbo Wang (daxian-dbw) requested changes Dec 18, 2018
View reviewed changes
Comment thread docs/host-powershell/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread docs/host-powershell/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Christoph Bergmeister (bergmeister) added 3 commits January 8, 2019 19:35
@bergmeister
Merge branch 'master' of https://github.com/bergmeister/PowerShell in…
09808fa 
…to updateExamples

# Conflicts:
#	docs/host-powershell/sample-dotnet1.1/Logic/UseRunspace.cs
#	docs/host-powershell/sample-dotnet1.1/MyApp/Program.cs
#	docs/host-powershell/sample-dotnet2.0-powershell.beta.1/Logic/UseRunspace.cs
#	docs/host-powershell/sample-dotnet2.0-powershell.beta.1/MyApp/Program.cs
@bergmeister
bring back docs about SetPowerShellAssemblyLoadContext
98551c8
@bergmeister
merge cross-platform sample (runtimes in the csproj) into the windows…
5442159 
… sample and rename to just sample
@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 8, 2019

Copy link
Copy Markdown
Contributor Author

Dongbo Wang (@daxian-dbw) I addressed your comments, the PR is up for re-review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Update the 'special hosting' section in readme
e1d4e2f
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Jan 11, 2019
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Christoph Bergmeister (@bergmeister) for the updates!
I updated the Special Hosting Scenario section of the readme. Everything else looks great!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Fix the spelling error
1d72d17
@daxian-dbw
Dongbo Wang (daxian-dbw) force-pushed the updateExamples branch from 29a07fe to 1d72d17 Compare January 11, 2019 20:04
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 1334b4c into PowerShell:master Jan 11, 2019
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jan 11, 2019
@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 14, 2019

Copy link
Copy Markdown
Contributor Author

Thanks Dongbo Wang (@daxian-dbw) . Do you mind explaining why the microsoft/nanoserver image is using a Core version of Windows PowerShell 5? To me it looks like a pre-Alpha version of PSCore, is this just for legacy or is this version of PowerShell supported/maintained?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@bergmeister @daxian-dbw
Update examples for hosting PSCore and remove old outdated examples (P…
c3ac594 
…owerShell#8472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister @daxian-dbw @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.