GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Style: Remove unneeded semi-colon and extra space before colon in named parameters by daxian-dbw · Pull Request #8504 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Dec 21, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

  • Remove unneeded stub types.
  • Remove unneeded semi-colon.
  • Remove extra space before colon in named parameters

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from Ilya (iSazonov) December 21, 2018 01:57
@daxian-dbw
Dongbo Wang (daxian-dbw) requested review from Bruce Payette (BrucePay), Paul Higinbotham (PaulHigin), Aditya Patwardhan (adityapatwardhan) and Mike Richmond (mirichmo) as code owners December 21, 2018 01:57
@daxian-dbw
Dongbo Wang (daxian-dbw) removed request for Bruce Payette (BrucePay), Paul Higinbotham (PaulHigin) and Mike Richmond (mirichmo) December 21, 2018 01:57
@daxian-dbw
[Feature] Remove extra space before colon in named parameters
fe8aa44
@daxian-dbw
Dongbo Wang (daxian-dbw) force-pushed the spaceAroundColon branch from 8ab725f to fe8aa44 Compare December 21, 2018 01:58
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Dec 21, 2018
View reviewed changes
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 21, 2018
iSazonov
Ilya (iSazonov) reviewed Dec 21, 2018
View reviewed changes
Comment thread src/System.Management.Automation/CoreCLR/CorePsStub.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 8d27eb4 into PowerShell:master Dec 21, 2018
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the spaceAroundColon branch December 21, 2018 18:26
@iSazonov Ilya (iSazonov) assigned Dongbo Wang (daxian-dbw) Dec 21, 2018
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log label Dec 22, 2018
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) removed the CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log label Jan 24, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw
Style: Remove extra space before colon in named parameters (PowerShel…
736811a 
…l#8504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@daxian-dbw @SteveL-MSFT @iSazonov @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.