GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Style: Remove space after new keyword in implicitly typed array allocation by daxian-dbw · Pull Request #8505 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Dec 21, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Remove space after new keyword in implicitly typed array allocation.
654 issues are fixed.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from Ilya (iSazonov) December 21, 2018 02:06
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from Bruce Payette (BrucePay) as a code owner December 21, 2018 02:06
@daxian-dbw
[Feature] Remove space after new keyword in implicitly typed array al…
38e0b32 
…location
@daxian-dbw
Dongbo Wang (daxian-dbw) force-pushed the spaceInNew branch from 35c68d5 to 38e0b32 Compare December 21, 2018 02:06
@daxian-dbw
Dongbo Wang (daxian-dbw) removed the request for review from Bruce Payette (BrucePay) December 21, 2018 02:08
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 21, 2018
iSazonov
Ilya (iSazonov) approved these changes Dec 21, 2018
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dongbo Wang (@daxian-dbw) Recently Jason noted that it makes sense to merge Types_Ps1Xml.cs and TypesV3_Ps1Xml.cs (perhaps some files from FormatAndOutput\DefaultFormatters too). I looked this but there are difficulties for me. The merging may speed up startup.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov Ilya (iSazonov) self-assigned this Dec 21, 2018
@iSazonov
Ilya (iSazonov) merged commit e999e1d into PowerShell:master Dec 21, 2018
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the spaceInNew branch December 21, 2018 18:08
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 21, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) What do you mean by merging them? Having a single .cs file that contains the type definitions for both? I don't think that alone will affect the perf, so there should be more that Jason wanted.
I did looked at the CPU time trace with the IL assemblies when working on the startup perf, and the huge yield methods in those 2 files does take an outstanding amount of the CPU time, over 2%. But the data is from IL assemblies and thus I'm not sure if it's really an issue with crossgen'ed assemblies. I couldn't generate PDBs for crossgen'ed assemblies.

I haven't contact .NET Core team on the crossgen related issues/questions. I moved to something with higher priority.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Dec 21, 2018

Copy link
Copy Markdown
Collaborator

Yes, single file. Jason simply mentioned that now there is no reason to have different files. Thanks for clarification about perf.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 22, 2018

Copy link
Copy Markdown
Member Author

I will get back to those huge yield state-machine methods when switching back to the CPU trace analysis work.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Dec 22, 2018

Copy link
Copy Markdown
Collaborator

Perhaps we could get more win by investigating to Jason's PSMore #7857. I guess that definitely yes at startup.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @iSazonov
Remove space after new keyword in implicitly typed array allocation (P…
97593be 
…owerShell#8505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@daxian-dbw @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.