GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Style: Member access symbols should be followed with member name by daxian-dbw · Pull Request #8517 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Dec 21, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Member access symbols should be followed with member name.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
[Feature] Member access symbols should be followed with member name
9bb64ef
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from Ilya (iSazonov) December 21, 2018 23:58
@daxian-dbw
Dongbo Wang (daxian-dbw) requested review from Bruce Payette (BrucePay), Francisco Gamino (Francisco-Gamino), Paul Higinbotham (PaulHigin), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Mike Richmond (mirichmo) as code owners December 21, 2018 23:58
@daxian-dbw
Dongbo Wang (daxian-dbw) removed request for Bruce Payette (BrucePay), Francisco Gamino (Francisco-Gamino), Paul Higinbotham (PaulHigin) and Mike Richmond (mirichmo) December 22, 2018 00:04
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 22, 2018
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Dec 22, 2018
View reviewed changes
Comment thread src/System.Management.Automation/engine/GetCommandCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
[Feature] Remove extra spaces as Steve suggested
09e9df0
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Dec 22, 2018
Style: Update StyleCop rules #8500
Merged
6 of 11 tasks
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Dec 22, 2018
View reviewed changes
iSazonov
Ilya (iSazonov) approved these changes Dec 22, 2018
View reviewed changes
@iSazonov Ilya (iSazonov) self-assigned this Dec 22, 2018
@iSazonov
Ilya (iSazonov) merged commit c5733f8 into PowerShell:master Dec 22, 2018
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the accessSymbol branch January 7, 2019 18:15
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @iSazonov
Style: Member access symbols should be followed with member name (Pow…
cbe8e76 
…erShell#8517)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@daxian-dbw @SteveL-MSFT @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.