GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — Code cleanup: convert usage of String to string by SteveL-MSFT · Pull Request #8520 · PowerShell/PowerShell Conversation
|
|
Please ignore my previous comment. I didn't notice this PR is specifically targeting |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It took me around 40 mins to go through the changes in this PR :)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GitHub "Load Diff" is very slow 😕 For such large PRs I think it is better to make one commit per module/assembly. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Steve Lee (@SteveL-MSFT) Please resolve merge conflicts. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
c14ac38 to
a13518e
Compare
|
Steve Lee (@SteveL-MSFT) Merge conflicts :-( |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Steve Lee (@SteveL-MSFT) Can we close the PR? Seems all fixed. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.