GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Style: Replace String.IsNullOrEmpty with string.IsNullOrEmpty by iSazonov · Pull Request #8557 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Dec 28, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Overlaps #8520 (where it is impossible to resolve many merge conflicts).

Fix case: replace String.IsNullOrEmpty with string.IsNullOrEmpty

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 28, 2018
@iSazonov
Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Dongbo Wang (daxian-dbw) December 28, 2018 12:58
@iSazonov
Ilya (iSazonov) requested review from Bruce Payette (BrucePay), Francisco Gamino (Francisco-Gamino), James Truher (JamesWTruher), Paul Higinbotham (PaulHigin), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Mike Richmond (mirichmo) as code owners December 28, 2018 12:58
@xtqqczze

xtqqczze commented Dec 28, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Job1 ElevatedPesterTests_xUnit_Packaging failed on PowerShell-CI-windows for #PR-8557-20181228.01:

##[Error 1]
The job running on agent Hosted Agent has exceeded the maximum execution time of 120.

Looking at the logs the root cause appears to be an network connectivity issue:

2018-12-28T13:10:20.2926238Z Failed to download package 'Microsoft.AspNetCore.Authentication.Cookies.2.1.2' from 'https://api.nuget.org/v3-flatcontainer/microsoft.aspnetcore.authentication.cookies/2.1.2/microsoft.aspnetcore.authentication.cookies.2.1.2.nupkg'.
2018-12-28T13:10:20.2926402Z The SSL connection could not be established, see inner exception.
2018-12-28T13:10:20.2926463Z Authentication failed because the remote party has closed the transport stream.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Ilya (iSazonov) added 4 commits December 29, 2018 18:20
@iSazonov
Commit 1
3682ed1
@iSazonov
Commit 2
7e35df1
@iSazonov
Commit 3
587f112
@iSazonov
Commit 4
a265ec1
@iSazonov
Ilya (iSazonov) force-pushed the style-string-isnullorempty branch from 3fd8f63 to a265ec1 Compare December 29, 2018 13:21
@iSazonov

Ilya (iSazonov) commented Dec 29, 2018

Copy link
Copy Markdown
Collaborator Author

Steve Lee (@SteveL-MSFT) Tests is passed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Dec 30, 2018
View reviewed changes
@iSazonov
[Feature]
26fa14d
@iSazonov Ilya (iSazonov) closed this Dec 31, 2018
@iSazonov Ilya (iSazonov) reopened this Dec 31, 2018
@iSazonov

Ilya (iSazonov) commented Dec 31, 2018

Copy link
Copy Markdown
Collaborator Author

Reopen to restart CIs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) closed this Dec 31, 2018
@iSazonov Ilya (iSazonov) reopened this Dec 31, 2018
@iSazonov
Ilya (iSazonov) merged commit 56569b9 into PowerShell:master Dec 31, 2018
@iSazonov
Ilya (iSazonov) deleted the style-string-isnullorempty branch December 31, 2018 10:10
@iSazonov Ilya (iSazonov) self-assigned this Jan 1, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov
Style: Replace String.IsNullOrEmpty with string.IsNullOrEmpty (PowerS…
e640022 
…hell#8557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
@Francisco-Gamino Francisco Gamino (Francisco-Gamino) Awaiting requested review from Francisco-Gamino
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
@mirichmo Mike Richmond (mirichmo) Awaiting requested review from mirichmo
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iSazonov @xtqqczze @SteveL-MSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.