GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Resolve :PAGER' if its path contains spaces #8130 by pougetat · Pull Request #8571 · PowerShell/PowerShell

Conversation

@pougetat

@pougetat pougetat (pougetat) commented Dec 31, 2018

Copy link
Copy Markdown

PR Summary

Resolve $env:PAGER if the path contains spaces #8130

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link: The 'help' function cannot use a program specified in the '$env:PAGER' if its path contains spaces #8130
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pougetat
pougetat (pougetat) requested review from Bruce Payette (BrucePay) and Dongbo Wang (daxian-dbw) as code owners December 31, 2018 15:09
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Dec 31, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pougetat
pougetat (pougetat) force-pushed the resolve-env-pager branch 2 times, most recently from 496c30c to f4c0102 Compare December 31, 2018 16:33
@iSazonov

Ilya (iSazonov) commented Dec 31, 2018

Copy link
Copy Markdown
Collaborator

pougetat (@pougetat) Please add test.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pougetat

pougetat (pougetat) commented Dec 31, 2018

Copy link
Copy Markdown
Author

Absolutely.
I've just left to go on vacation but will be back in a few days to do just that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) assigned Aditya Patwardhan (adityapatwardhan) Jan 1, 2019
@pougetat
pougetat (pougetat) force-pushed the resolve-env-pager branch from f4c0102 to 1da21db Compare January 7, 2019 14:19
@pougetat

pougetat (pougetat) commented Jan 7, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

Hey Aditya Patwardhan (@adityapatwardhan), Ilya (@iSazonov)
I've updated the PR with a test file :)
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov
Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Travis Plunk (TravisEz13) January 8, 2019 10:16
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Jan 8, 2019
View reviewed changes
Comment thread src/System.Management.Automation/engine/InitialSessionState.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/engine/Help/HelpSystem.Tests.ps1 Outdated

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Jan 8, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

James Truher (@JamesWTruher) Any suggestions on how we could avoid using less.exe?
pougetat (@pougetat) We do not expect that git must be installed on test environments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@pougetat pougetat (pougetat) Jan 11, 2019

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Aditya Patwardhan (@adityapatwardhan) , James Truher (@JamesWTruher)
I made the modifs that were asked. Any update on this particular question ? :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jan 11, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing, we don't need to use an actual pager. If the test is to validate piping data to something that has a space in the path, why not just use something like:

Join-Path $TestDrive "folder with spaces\pager.ps1"

Where pager.ps1 is simply takes input from pipeline (some test text) and outputs a hash you can verify?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pougetat reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread test/powershell/engine/Help/HelpSystem.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pougetat
pougetat (pougetat) force-pushed the resolve-env-pager branch from 1da21db to b71a87c Compare January 9, 2019 16:36
TravisEz13
Travis Plunk (TravisEz13) requested changes Jan 9, 2019
View reviewed changes
Comment thread src/System.Management.Automation/engine/InitialSessionState.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pougetat
pougetat (pougetat) force-pushed the resolve-env-pager branch 8 times, most recently from f281265 to 01da326 Compare January 10, 2019 13:26
TravisEz13
Travis Plunk (TravisEz13) reviewed Jan 15, 2019
View reviewed changes
Comment thread src/System.Management.Automation/engine/InitialSessionState.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) requested changes Jan 15, 2019
View reviewed changes
Comment thread test/powershell/engine/Help/HelpSystem.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pougetat
pougetat (pougetat) force-pushed the resolve-env-pager branch from 01da326 to 0b3092a Compare January 16, 2019 09:54
@throwaway774
Resolve :PAGER' if its path contains spaces
8cfb993
@pougetat
pougetat (pougetat) force-pushed the resolve-env-pager branch from 0b3092a to 8cfb993 Compare January 16, 2019 12:07
TravisEz13
Travis Plunk (TravisEz13) approved these changes Jan 16, 2019
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 16, 2019

Copy link
Copy Markdown
Member

Aditya Patwardhan (@adityapatwardhan) looks good to me now
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jan 16, 2019
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 4858afb into PowerShell:master Jan 16, 2019
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 16, 2019
@iSazonov

Ilya (iSazonov) commented Jan 17, 2019

Copy link
Copy Markdown
Collaborator

pougetat (@pougetat) Thanks for your contribution!
pougetat reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
pougetat @adityapatwardhan
Resolve :PAGER' if its path contains spaces (PowerShell#8571)
09d18e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@pougetat @msftclas @iSazonov @TravisEz13 @SteveL-MSFT @adityapatwardhan @throwaway774
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.