GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make `Join-String -InputObject 1,2,3` result equal to `1,2,3 | Join-String` result by sethvs · Pull Request #8611 · PowerShell/PowerShell

Conversation

@sethvs

@sethvs Sergey Vasin (sethvs) commented Jan 9, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Make Join-String -InputObject 1,2,3 result equal to 1,2,3 | Join-String result.

Fix #8610

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sethvs
Join-String -InputObject 1,2,3 result is now equal to 1,2,3 | Join-St…
7523a4c 
…ring result
@sethvs
Sergey Vasin (sethvs) requested review from James Truher (JamesWTruher) and Paul Higinbotham (PaulHigin) as code owners January 9, 2019 06:58
@sethvs
Add test.
8d15613
iSazonov
Ilya (iSazonov) reviewed Jan 9, 2019
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-string.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sethvs
Add null check.
6de82b7
iSazonov
Ilya (iSazonov) reviewed Jan 9, 2019
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-string.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Jan 9, 2019
Ilya (iSazonov) and others added 2 commits January 9, 2019 14:50
@iSazonov @sethvs
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/joi…
a0fdbc6 
…n-string.cs

Co-Authored-By: sethvs <[email protected]>
@sethvs
Revert previous commit.
e9c5e30
PaulHigin
Paul Higinbotham (PaulHigin) previously approved these changes Jan 10, 2019
View reviewed changes
@PaulHigin
Paul Higinbotham (PaulHigin) dismissed their stale review January 10, 2019 00:10

Sorry, I approved the wrong PR. I'll look at this soon.

@TravisEz13 Travis Plunk (TravisEz13) added Breaking-Change breaking change that may affect users CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision Review - Committee The PR/Issue needs a review from the PowerShell Committee and removed Committee-Reviewed PS-Committee has reviewed this and made a decision labels Jan 17, 2019
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 17, 2019

Copy link
Copy Markdown
Member

Requesting committee review for the new behavior
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Jan 17, 2019
View reviewed changes
@iSazonov Ilya (iSazonov) changed the title Make Join-String -InputObject 1,2,3 result equal to 1,2,3 | Join-String result WIP: Make Join-String -InputObject 1,2,3 result equal to 1,2,3 | Join-String result Jan 18, 2019
@iSazonov

Ilya (iSazonov) commented Jan 18, 2019

Copy link
Copy Markdown
Collaborator

Add WIP until PowerShell Committee review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT Steve Lee (SteveL-MSFT) added Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Jan 24, 2019
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jan 24, 2019

Copy link
Copy Markdown
Member

@PowerShell/powershell-committee reviewed this. In this particular case because it's dealing with strings, it is acceptable to have this desired behavior. Since Join-String is new, the risk of impact is low although it is a breaking change.
iSazonov reacted with thumbs up emoji vexx32 reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sethvs Sergey Vasin (sethvs) changed the title WIP: Make Join-String -InputObject 1,2,3 result equal to 1,2,3 | Join-String result Make Join-String -InputObject 1,2,3 result equal to 1,2,3 | Join-String result Jan 24, 2019
@sethvs

Sergey Vasin (sethvs) commented Jan 24, 2019

Copy link
Copy Markdown
Contributor Author

PowerShell Committee reviewed this, so remove WIP.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Jan 24, 2019
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit a9841d9 into PowerShell:master Jan 24, 2019
@iSazonov

Ilya (iSazonov) commented Jan 25, 2019

Copy link
Copy Markdown
Collaborator

Sergey Vasin (@sethvs) Thanks for your contribution!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sethvs
Sergey Vasin (sethvs) deleted the joinString2 branch January 25, 2019 08:01
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@sethvs @TravisEz13
Make Join-String -InputObject 1,2,3 result equal to `1,2,3 | Join-S…
29da0e2 
…tring` result (PowerShell#8611)

Make `Join-String -InputObject 1,2,3` result equal to `1,2,3 | Join-String` result.

Fix PowerShell#8610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
+2 more reviewers
@vexx32 Rain Sallow (/u/ta11ow) (vexx32) vexx32 left review comments
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

Breaking-Change breaking change that may affect users CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Join-String -InputObject 1,2,3 result is not equal to 1,2,3 | Join-String result.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sethvs @TravisEz13 @iSazonov @SteveL-MSFT @PaulHigin @vexx32
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.