GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Create Support File by RDIL · Pull Request #8618 · PowerShell/PowerShell

Conversation

@RDIL

@RDIL Reece Dunham (RDIL) commented Jan 9, 2019

Copy link
Copy Markdown
Contributor

PR Summary

Added markdown file for support, GitHub will know about the file and put it on the sidebar under Helpful resources over there ----->

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RDIL
Reece Dunham (RDIL) requested review from Travis Plunk (TravisEz13) and Joey Aiello (joeyaiello) as code owners January 9, 2019 14:53
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Jan 9, 2019
TravisEz13
Travis Plunk (TravisEz13) reviewed Jan 9, 2019
View reviewed changes
Comment thread .github/SUPPORT.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) requested changes Jan 9, 2019
View reviewed changes

@TravisEz13 Travis Plunk (TravisEz13) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RDIL

Reece Dunham (RDIL) commented Jan 9, 2019

Copy link
Copy Markdown
Contributor Author

fixed!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Jan 11, 2019

Copy link
Copy Markdown
Contributor Author

Codacity is gone yay
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 16, 2019

Copy link
Copy Markdown
Member

Codacity Supports PowerShell Script analyzer. We can consider disabling rules. It also run analysis we are required to look at and evaluate the results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Reece Dunham (RDIL) added 7 commits January 16, 2019 15:12
@RDIL @TravisEz13
Create SUPPORT.md
312a96c
@RDIL @TravisEz13
Push updated readme
464316a
@RDIL @TravisEz13
markdownlint = annoying
5595b54
@RDIL @TravisEz13
Address feedback
a2e25be
@RDIL @TravisEz13
Update SUPPORT.md
633ced1
@RDIL @TravisEz13
Simple move
a7a83bc
@RDIL @TravisEz13
Codacity stop bullying me
b809478
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 16, 2019

Copy link
Copy Markdown
Member

I rebased your PR to master to trigger the latest static analysis.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Jan 16, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

failed, failed again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Jan 16, 2019

Copy link
Copy Markdown
Contributor Author

What does this mean?:

2019-01-16T23:19:44.0996261Z   Describing Common Tests - Validate Markdown Files
2019-01-16T23:19:44.0996343Z VERBOSE: NPM is checking Gulp is installed. This may take a few moments.
2019-01-16T23:20:08.6540685Z     [+] Should not have errors in any markdown files 25.25s
2019-01-16T23:20:08.6717885Z Tests completed in 159.46s
2019-01-16T23:20:08.6972505Z Tests Passed: 431, Failed: 1, Skipped: 0, Pending: 2, Inconclusive: 0 
2019-01-16T23:20:09.9762947Z markdown link tests failed
2019-01-16T23:20:09.9763679Z At /home/vsts/work/_temp/556706ef-519c-4971-8ccf-5d3722c2cbeb.ps1:8 char:3
2019-01-16T23:20:09.9763748Z +   throw "markdown link tests failed"
2019-01-16T23:20:09.9763840Z +   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-01-16T23:20:09.9763892Z + CategoryInfo          : OperationStopped: (markdown link tests failed:String) [], RuntimeException
2019-01-16T23:20:09.9763971Z + FullyQualifiedErrorId : markdown link tests failed
2019-01-16T23:20:09.9764053Z  
2019-01-16T23:20:09.9817530Z ##[error]PowerShell exited with code '1'.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 16, 2019

Copy link
Copy Markdown
Member

I'll fix the link issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 16, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Go to the tests tab and it will show you what test failed.
image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Jan 16, 2019

Copy link
Copy Markdown
Contributor Author

Oh that exists thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 16, 2019

Copy link
Copy Markdown
Member

The windows failure is a very intermittent failure. It should pass on rerun. I'm not going to rerun because we should make the broken link relative so the PR will pass.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Jan 16, 2019

Copy link
Copy Markdown
Contributor Author

Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 16, 2019

Copy link
Copy Markdown
Member

Actually, I was thinking about it and the link cannot be relative. I'll force merge with the failure. I've reset back to before I made the change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Jan 17, 2019

Copy link
Copy Markdown
Contributor Author

Oh ok
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL
[feature] add to markdownlint checks
acbfaa7
@TravisEz13
Travis Plunk (TravisEz13) merged commit 41e63f6 into PowerShell:master Jan 17, 2019
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 17, 2019

Copy link
Copy Markdown
Member

Used admin to merge. The only failure was a new link added in this PR which failed to verify.

Reece Dunham (@RDIL) We could adjust the test for this scenario so that if the URL has ?AddedInPr=8618 where the PR matches the current PR number, it ignores the failure. Most sites will ignore the query string for static content.

Aditya Patwardhan (@adityapatwardhan) What do you think?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL
Reece Dunham (RDIL) deleted the patch-4 branch January 17, 2019 20:31
@RDIL

Reece Dunham (RDIL) commented Jan 17, 2019

Copy link
Copy Markdown
Contributor Author

That would most likely be the best option.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@PaulHigin Paul Higinbotham (PaulHigin) added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jan 24, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@RDIL @TravisEz13
Create Support File (PowerShell#8618)
c59069e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 requested changes
@joeyaiello Joey Aiello (joeyaiello) Awaiting requested review from joeyaiello

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@RDIL @TravisEz13 @PaulHigin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.