GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update the pull request template by RDIL · Pull Request #8624 · PowerShell/PowerShell

Conversation

@RDIL

@RDIL Reece Dunham (RDIL) commented Jan 11, 2019

Copy link
Copy Markdown
Contributor

PR Summary

Just some misc. cleanup/enhancements to make it easier to understand.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RDIL
Update the pull request template
68cbeb1
@RDIL
Reece Dunham (RDIL) requested review from Travis Plunk (TravisEz13) and Joey Aiello (joeyaiello) as code owners January 11, 2019 14:58
vexx32
Rain Sallow (/u/ta11ow) (vexx32) reviewed Jan 11, 2019
View reviewed changes
Comment thread .github/PULL_REQUEST_TEMPLATE.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RDIL
Update PULL_REQUEST_TEMPLATE.md
8c5da9f
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Dongbo Wang (daxian-dbw) Jan 11, 2019
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Jan 11, 2019
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit b30edf4 into PowerShell:master Jan 11, 2019
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Jan 11, 2019

Copy link
Copy Markdown
Member

Thanks Reece Dunham (@RDIL) for the contribution!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL
Reece Dunham (RDIL) deleted the patch-5 branch January 11, 2019 19:34
@iSazonov Ilya (iSazonov) added the CL-Untagged label Jan 17, 2019
@PaulHigin Paul Higinbotham (PaulHigin) added CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log and removed CL-Untagged labels Jan 24, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@RDIL @daxian-dbw
Update the pull request template (PowerShell#8624)
9b53baf 
Some cleanup/enhancements to make it easier to understand.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@joeyaiello Joey Aiello (joeyaiello) Awaiting requested review from joeyaiello
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
+1 more reviewer
@vexx32 Rain Sallow (/u/ta11ow) (vexx32) vexx32 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@RDIL @daxian-dbw @vexx32 @PaulHigin @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.