GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add function to create a framework dependent package dotnet-sdk containers by adityapatwardhan · Pull Request #8644 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Jan 14, 2019

Copy link
Copy Markdown
Member

PR Summary

Create a framework dependent package with reduced size specially for docker containers based on dotnet-sdk containers.

PR Context

The size of the framework dependent package is pretty large. It has assemblies of runtimes which are not required for the dotnet-sdk container images. This PR creates a new package with a reduced size.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@adityapatwardhan
Add function to create a framework dependent package dotnet-sdk conta…
25956bb
…iners
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners January 14, 2019 22:53
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) assigned Travis Plunk (TravisEz13) Jan 14, 2019
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 14, 2019
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Jan 14, 2019
View reviewed changes
Comment thread tools/packaging/packaging.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan
Address Paul's comments
9c6f98d
TravisEz13
Travis Plunk (TravisEz13) reviewed Jan 15, 2019
View reviewed changes
Comment thread tools/packaging/packaging.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

TravisEz13
Travis Plunk (TravisEz13) reviewed Jan 15, 2019
View reviewed changes
Comment thread tools/packaging/packaging.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

TravisEz13
Travis Plunk (TravisEz13) reviewed Jan 15, 2019
View reviewed changes
Comment thread tools/packaging/packaging.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

TravisEz13
Travis Plunk (TravisEz13) requested changes Jan 15, 2019
View reviewed changes

@TravisEz13 Travis Plunk (TravisEz13) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like you to fix the Write-Log comment before merging.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Aditya Patwardhan (adityapatwardhan) added 2 commits January 14, 2019 16:58
@adityapatwardhan
Add rollForwardOnNoCandidateFx and update package tests
ff29f95
@adityapatwardhan
Address Travis's comments and Codacy reported issue
93e2ac4
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 15, 2019

Copy link
Copy Markdown
Member Author

Travis Plunk (@TravisEz13) can you re-review, your comments have been addressed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 15, 2019

Copy link
Copy Markdown
Member Author

Andrew (@anmenaga) - Please have a look I have made changes to package verification tests.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 15, 2019

Copy link
Copy Markdown
Member Author

Codacy error is due to Write-Host which is needed.
CodeFactor is complaining about docker files. Similar issues exists in all our docker files.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anmenaga
Andrew (anmenaga) approved these changes Jan 15, 2019
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) approved these changes Jan 16, 2019
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit be4b82c into PowerShell:master Jan 16, 2019
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the buildtest branch January 16, 2019 00:28
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Add function to create a framework dependent package dotnet-sdk conta…
e70e7c3
…iners (PowerShell#8644)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+2 more reviewers
@anmenaga Andrew (anmenaga) anmenaga approved these changes
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@adityapatwardhan @TravisEz13 @anmenaga @PaulHigin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.