GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs(contributing): add link check information by RDIL · Pull Request #8659 · PowerShell/PowerShell

Conversation

@RDIL

@RDIL Reece Dunham (RDIL) commented Jan 16, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

title

PR Context

Travis Plunk (@TravisEz13) told me to do this
Travis if your reading this just know I have to update the other file please no merge yet

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RDIL
Update CONTRIBUTING.md
bae40df
@RDIL
Reece Dunham (RDIL) requested review from Travis Plunk (TravisEz13) and Joey Aiello (joeyaiello) as code owners January 16, 2019 00:46
@TravisEz13 Travis Plunk (TravisEz13) self-assigned this Jan 16, 2019
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Jan 16, 2019
View reviewed changes
Comment thread .github/CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Aditya Patwardhan (adityapatwardhan) and others added 3 commits January 15, 2019 20:31
@adityapatwardhan @RDIL
Use Aditya's feedback
76df967 
Co-Authored-By: RDIL <[email protected]>
@RDIL
Update CONTRIBUTING.md
17b9e44
@RDIL
escape the ;
e24177d
@RDIL Reece Dunham (RDIL) changed the title [ WIP ] docs(contributing): add link check information docs(contributing): add link check information Jan 16, 2019
@RDIL

Reece Dunham (RDIL) commented Jan 16, 2019

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) feedback addressed, Travis Plunk (@TravisEz13) ready for review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Reece Dunham (RDIL) added 2 commits January 15, 2019 20:42
@RDIL
now the command is perfect
f522a96
@RDIL
Update CONTRIBUTING.md
68284c8
alexandair
Aleksandar Nikolić (alexandair) reviewed Jan 16, 2019
View reviewed changes
Comment thread .github/CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
alexandair
Aleksandar Nikolić (alexandair) reviewed Jan 16, 2019
View reviewed changes
Comment thread .github/CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Reece Dunham (RDIL) and others added 3 commits January 16, 2019 13:42
@RDIL
Update CONTRIBUTING.md
03b2edc
@RDIL
Update CONTRIBUTING.md
38af28d
@RDIL
Update CONTRIBUTING.md
937c49b
@RDIL

Reece Dunham (RDIL) commented Jan 16, 2019

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) please re-review since requested changes were addressed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jan 16, 2019
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) reviewed Jan 16, 2019
View reviewed changes
Comment thread .github/CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) reviewed Jan 16, 2019
View reviewed changes
Comment thread .github/CONTRIBUTING.md
* if the `.spelling` file is updated, commit and push it

#### Checking links in documentation
Documentation is link-checked. We make use of the

@TravisEz13 Travis Plunk (TravisEz13) Jan 16, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest saying that this and markdown syntax checking (like the newline before and after headers.) can be checked by running start-pspester -includecommontests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@RDIL Reece Dunham (RDIL) Jan 16, 2019

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
TravisEz13
Travis Plunk (TravisEz13) reviewed Jan 16, 2019
View reviewed changes
Comment thread .github/CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RDIL
fix 1
06099a5
TravisEz13
Travis Plunk (TravisEz13) reviewed Jan 16, 2019
View reviewed changes
Comment thread .github/CONTRIBUTING.md
#### Spellchecking documentation

Documentation are spellchecked. We make use of the
Documentation is spellchecked. We use the

@TravisEz13 Travis Plunk (TravisEz13) Jan 16, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file apparently isn't being checked for markdown syntax issues.
You can add it by updating this list

PowerShell/test/common/markdown/markdown.tests.ps1

Lines 57 to 67 in 03cd3a2

'./.github/CONTRIBUTING.md'
'./*.md'
'./demos/python/*.md'
'./docker/*.md'
'./docs/*.md'
'./docs/building/*.md'
'./docs/cmdlet-example/*.md'
'./docs/maintainers/*.md'
'./docs/testing-guidelines/testing-guidelines.md'
'./test/powershell/README.md'
'./tools/*.md'

Not a requirement. If you are using, vscode, you can just install the markdownlinq extension and you should get the issues as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@RDIL Reece Dunham (RDIL) Jan 16, 2019

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Reece Dunham (RDIL) and others added 2 commits January 16, 2019 17:40
@RDIL
Fix 2/3
d3834f6
RDIL
fix 3/4
b4a1557
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 16, 2019

Copy link
Copy Markdown
Member

Thanks a lot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jan 16, 2019
@TravisEz13
Travis Plunk (TravisEz13) merged commit 9eb6fc9 into PowerShell:master Jan 16, 2019
@RDIL
Reece Dunham (RDIL) deleted the patch-2 branch January 16, 2019 23:35
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@RDIL @TravisEz13
docs(contributing): add link check information (PowerShell#8659)
d017e33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 left review comments
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@joeyaiello Joey Aiello (joeyaiello) Awaiting requested review from joeyaiello
+1 more reviewer
@alexandair Aleksandar Nikolić (alexandair) alexandair left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@RDIL @TravisEz13 @alexandair @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.