GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Build package build using ubuntu 18.04 image by adityapatwardhan · Pull Request #8666 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Jan 16, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Change the base image for package builds from ubuntu14.04 to ubuntu 18.04 due to failure in installing fpm.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan
Build package build using ubuntu 16.04 image
e5abbe3
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Travis Plunk (TravisEz13) January 16, 2019 20:15
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Paul Higinbotham (PaulHigin), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners January 16, 2019 20:15
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 16, 2019

Copy link
Copy Markdown
Member Author

The ubuntu.14.04_amd64.deb was tested from a private build on a ubuntu.14.04 container
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Jan 16, 2019
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan
Use ubuntu 18.04 image
04a5d5b
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Jan 16, 2019
Install rdoc to fix linux build on ubuntu 14.04 #8665
Closed
11 tasks
RDIL
Reece Dunham (RDIL) approved these changes Jan 16, 2019
View reviewed changes
Aditya Patwardhan (adityapatwardhan) added 3 commits January 16, 2019 14:01
@adityapatwardhan
Update the version for libicu
ccbaa80
@adityapatwardhan
Update libicu version in dockerfile
8dc81d0
@adityapatwardhan
Update libcurl version
d0648b6
TravisEz13
Travis Plunk (TravisEz13) approved these changes Jan 16, 2019
View reviewed changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title Build package build using ubuntu 16.04 image Build package build using ubuntu 18.04 image Jan 16, 2019
@TravisEz13
Travis Plunk (TravisEz13) merged commit f03cafb into PowerShell:master Jan 16, 2019
@iSazonov Ilya (iSazonov) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 17, 2019
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Jan 17, 2019
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the ChangePackageImageTo16_04 branch January 25, 2019 23:46
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request May 14, 2019
@adityapatwardhan @TravisEz13
Build package build using ubuntu 18.04 image (PowerShell#8666)
b9d7006 
# Conflicts:
#	tools/releaseBuild/build.json
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan @TravisEz13
Build package build using ubuntu 18.04 image (PowerShell#8666)
cb0ea03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
+1 more reviewer
@RDIL Reece Dunham (RDIL) RDIL approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@adityapatwardhan @daxian-dbw @TravisEz13 @RDIL @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.