GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Batch merge builds together while a merge build is running by TravisEz13 · Pull Request #8668 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Jan 16, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Batch merge builds together while a merge build is running

PR Context

Help keep agents available for CI runs.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Travis Plunk (TravisEz13) requested review from Paul Higinbotham (PaulHigin), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners January 16, 2019 23:24
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 16, 2019

Copy link
Copy Markdown
Member

Missing Linux yml
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Batch merge builds together while a merge build is running
65fca86
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the batch_merge_builds branch from 1076eaa to 65fca86 Compare January 16, 2019 23:28
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jan 16, 2019
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 4d69997 into PowerShell:master Jan 16, 2019
@TravisEz13
Travis Plunk (TravisEz13) deleted the batch_merge_builds branch January 16, 2019 23:29
@iSazonov Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jan 17, 2019
@iSazonov

Ilya (iSazonov) commented Jan 17, 2019

Copy link
Copy Markdown
Collaborator

Travis Plunk (@TravisEz13) Could you please add more info about benefits of the change for my education?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vexx32

Rain Sallow (/u/ta11ow) (vexx32) commented Jan 17, 2019

Copy link
Copy Markdown
Collaborator

Ilya (@iSazonov) See here:

https://docs.microsoft.com/en-us/azure/devops/pipelines/build/triggers?view=vsts&tabs=yaml#continuous-integration-ci

I could be missing some nuances also, but it appears that they're looking to batch together builds that originate from the same PR in order to allow Azure to queue a batch job if someone pushes a bunch of commits in quick succession; it will simply build them as one, shortening the overall build time. 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Jan 17, 2019

Copy link
Copy Markdown
Collaborator

Rain Sallow (/u/ta11ow) (@vexx32) Thanks. I still don't understand how it works really.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 17, 2019

Copy link
Copy Markdown
Member Author

This does not batch PR builds. This batches merge (or as Azure DevOps calls them CI builds) while a merge build is in progress.

So if we merge PR A and a merge build starts.

Then we merge PR B and C while the build for PR A is still running, the next build will build B & C.

The feature Rain Sallow (/u/ta11ow) (@vexx32) mentioned is on by default.
vexx32 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Jan 18, 2019

Copy link
Copy Markdown
Collaborator

Thanks Travis Plunk (@TravisEz13) !
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vexx32

Rain Sallow (/u/ta11ow) (vexx32) commented Jan 18, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Appreciate the clarification, looks like I gotta brush up on the yml spec once again! 😄
TravisEz13 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Batch merge builds together while a merge build is running (PowerShel…
9e2399a 
…l#8668)

## PR Summary

Batch merge builds together while a merge build is running 

## PR Context  

Help keep agents available for CI runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@TravisEz13 @adityapatwardhan @iSazonov @vexx32
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.