GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix the build for fxdependent build for dotnet sdk by adityapatwardhan · Pull Request #8670 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Jan 17, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Fix the build for fxdependent build for dotnet sdk.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Aditya Patwardhan (adityapatwardhan) added 3 commits January 16, 2019 15:23
@adityapatwardhan
Add debug logging
a8564fc
@adityapatwardhan
Use $Environment.IsWindows instead of $IsWindows
fed0839
@adityapatwardhan
Remove excessive logging
c5b75d7
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners January 17, 2019 00:36
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title Fix the build for fxdependent build for dotnet sdk WIP: Fix the build for fxdependent build for dotnet sdk Jan 17, 2019
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 17, 2019

Copy link
Copy Markdown
Member Author

Marked it WIP as I am still testing the private build.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Aditya Patwardhan (adityapatwardhan) added 2 commits January 16, 2019 17:07
@adityapatwardhan
Fix package path
c2259bd
@adityapatwardhan
Fix zip file and artifact upload location
dec982d
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title WIP: Fix the build for fxdependent build for dotnet sdk Fix the build for fxdependent build for dotnet sdk Jan 18, 2019
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 18, 2019

Copy link
Copy Markdown
Member Author

Travis Plunk (@TravisEz13) - This is ready for review and required for next release
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 19, 2019

Copy link
Copy Markdown
Member

Was there changes to the build definition?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Jan 19, 2019
View reviewed changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) assigned Travis Plunk (TravisEz13) Jan 22, 2019
@TravisEz13
Travis Plunk (TravisEz13) merged commit cf013dd into PowerShell:master Jan 22, 2019
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the FixWinDotnetSdkBuild branch January 22, 2019 19:25
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 23, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan @TravisEz13
Fix the build for fxdependent build for dotnet sdk (PowerShell#8670)
6a7314d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@adityapatwardhan @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.