GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove broken HelpUri from CimTest by xtqqczze · Pull Request #8688 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Jan 18, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Remove broken HelpUri from CimTest.cdxml as it appears to be redundant.

PR Context

During #8622 it was found this URI is broken as the fwlink redirects to http://technet.microsoft.comlibrary/jj635727(v=wps.620).aspx (note missing forward slash)

With the missing forward slash added the fwlink redirects to http://docs.microsoft.com/en-us/powershell/module/smbshare/set-smbshare?view=winserver2012-ps1 which doesn't appear to be relevant to the test.

James Truher (@JamesWTruher)

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
  • Testing - New and feature
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xtqqczze
[WIP] Remove broken HelpUri from CimTest
852ea23 
Fwlink redirects to `http://technet.microsoft.comlibrary/jj635727(v=wps.620).aspx`. With the missing forward slash added the fwlink redirects to `http://docs.microsoft.com/en-us/powershell/module/smbshare/set-smbshare?view=winserver2012-ps1`
@xtqqczze xtqqczze mentioned this pull request Jan 18, 2019
Use https in URLs where available #8622
Merged
8 tasks done
@xtqqczze
[Feature] Empty commit for CI
4d1f861
@xtqqczze xtqqczze changed the title [WIP] Remove broken HelpUri from CimTest Remove broken HelpUri from CimTest Jan 18, 2019
@daxian-dbw
Dongbo Wang (daxian-dbw) requested review from James Truher (JamesWTruher) and Aditya Patwardhan (adityapatwardhan) January 18, 2019 19:33
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan) Jan 18, 2019
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 18, 2019
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jan 18, 2019
View reviewed changes
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 18, 2019

Copy link
Copy Markdown
Member

The change looks good. Does not seem to be used in any tests. We typically wait 24 hours for the PR for comments. I will merge this then.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 1df96c7 into PowerShell:master Jan 22, 2019
@xtqqczze
xtqqczze deleted the SetCimTest-HelpUri branch April 24, 2019 22:59
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze @adityapatwardhan
Remove broken HelpUri from CimTest (PowerShell#8688)
7fa7994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @adityapatwardhan @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.