GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove extra AppVeyor environment check by RDIL · Pull Request #8709 · PowerShell/PowerShell

Conversation

@RDIL

@RDIL Reece Dunham (RDIL) commented Jan 22, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Removes a check for AppVeyor env

PR Context

AppVeyor removed (#8686 extension)

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: [docs] [code] AppVeyor/Travis CI references exist #8686
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RDIL
Remove extra appveyor enviornment check
f39be9f
@RDIL Reece Dunham (RDIL) changed the title Remove extra appveyor environment check Remove extra AppVeyor environment check Jan 22, 2019
@RDIL
[feature] trigger feature tests
1134165
bergmeister
Christoph Bergmeister (bergmeister) suggested changes Jan 23, 2019
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I realised only now that appveyor.yml is now completely gone. This change is ok

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Jan 23, 2019
View reviewed changes
iSazonov
Ilya (iSazonov) approved these changes Jan 23, 2019
View reviewed changes
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Jan 23, 2019
@iSazonov

Ilya (iSazonov) commented Jan 23, 2019

Copy link
Copy Markdown
Collaborator

Do we still use appveyor.psm1 ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Jan 23, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Yeah, the Windows VSTS agent imports it. It could be renamed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Jan 23, 2019

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) https://github.com/PowerShell/PowerShell/blob/master/.vsts-ci/windows.yml#L70
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Jan 23, 2019

Copy link
Copy Markdown
Collaborator

Thanks. I see. Maybe need rename...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Jan 23, 2019

Copy link
Copy Markdown
Contributor Author

I can do that if you would like.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Jan 23, 2019

Copy link
Copy Markdown
Collaborator

Not in the PR and if Travis Plunk (@TravisEz13) agrees.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Jan 23, 2019

Copy link
Copy Markdown
Contributor Author

Alright, if Mr. Plunk gives his 👍 then I'll open a different PR for it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) reviewed Jan 24, 2019
View reviewed changes
Comment thread test/packaging/windows/msi.tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Feb 8, 2019

Copy link
Copy Markdown
Collaborator

Travis Plunk (@TravisEz13) Could you please merge?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Feb 8, 2019
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 3ab7e2e into PowerShell:master Feb 8, 2019
@TravisEz13 Travis Plunk (TravisEz13) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Feb 8, 2019
@RDIL
Reece Dunham (RDIL) deleted the patch-1 branch February 8, 2019 19:10
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@RDIL @TravisEz13
Remove extra AppVeyor environment check (PowerShell#8709)
8f91e5c 
Removes a check for AppVeyor env

## PR Context  
AppVeyor removed (PowerShell#8686  extension)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
+1 more reviewer
@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@RDIL @iSazonov @bergmeister @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.