GeezerVison

PR Summary

AMSI is not getting uninitialized when a PowerShell shell window is closed by clicking the 'close' button instead of typing 'exit' at the command line, because the final runspace is not being closed. There is an assert checking for AMSI uninitialized during a CLR process exit, and it fires every time the window is closed via the close button. This fix removes the assert and replaces it with a check and call to uninitialize AMSI.

PR Context

The assert is very annoying and does nothing useful.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Change is not breaking
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
    • Add [feature] to your commit messages if the change is significant or affects feature tests