GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Send-MailMessage: add parameter "ReplyTo" by replicaJunction · Pull Request #8727 · PowerShell/PowerShell

Conversation

@replicaJunction

@replicaJunction Joshua T (replicaJunction) commented Jan 23, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Adds a -ReplyTo parameter to Send-MailMessage, which allows users to include the Reply-To field in their e-mail messages.

PR Context

Fixes issue #8719.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: Add documentation for new -ReplyTo parameter in Send-MailMessage MicrosoftDocs/PowerShell-Docs#3602
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@replicaJunction
Send-MailMessage: add parameter "ReplyTo"
65f6716
Fixes issue PowerShell#8719.
@replicaJunction
Joshua T (replicaJunction) requested review from James Truher (JamesWTruher) and Paul Higinbotham (PaulHigin) as code owners January 23, 2019 23:10
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Jan 23, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Jan 24, 2019
@iSazonov

Ilya (iSazonov) commented Jan 24, 2019

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) Public API need approval by PowerShell Committee .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Jan 24, 2019

Copy link
Copy Markdown
Collaborator

Joshua T (@replicaJunction) Thanks for your contribution!

Please add tests (see Send-MailMessage.Tests.ps1 file).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@replicaJunction

Joshua T (replicaJunction) commented Jan 24, 2019

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) I may need help adding tests for this. I did test interactively, and the reply-to field was correctly populated in an e-mail message, but even the existing Pester tests won't run on my development box since they're hard-coded to run only on Linux.

If I'm reading correctly, it looks like the existing tests actually call a mail server running on the local machine to send a message, and then they read the message back from disk. Could someone with easy access to a Linux device help with Pester tests?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@replicaJunction Joshua T (replicaJunction) mentioned this pull request Jan 24, 2019
Add documentation for new -ReplyTo parameter in Send-MailMessage MicrosoftDocs/PowerShell-Docs#3602
Closed
2 of 8 tasks
@iSazonov

Ilya (iSazonov) commented Jan 24, 2019

Copy link
Copy Markdown
Collaborator

Joshua T (@replicaJunction) You could create new test like existing in Send-MailMessage.Tests.ps1 and push the commit - then you'll see result in CI (click Detail link).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@replicaJunction
Add tests for Send-MailMessage -ReplyTo
ed2034e
@replicaJunction

Joshua T (replicaJunction) commented Jan 30, 2019

Copy link
Copy Markdown
Contributor Author

I've added the -ReplyTo parameter to the existing tests, and it looks like they passed.

Regarding the CodeFactor issue above, I wrote the line in question to match the style of the existing code in that switch block. I don't think that issue can be fixed without reformatting the entire block, and I didn't want to clutter up this PR with formatting changes to others' code.

iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) approved these changes Jan 30, 2019
View reviewed changes
@iSazonov Ilya (iSazonov) assigned Andrew (anmenaga) Jan 30, 2019
@anmenaga

Andrew (anmenaga) commented Jan 30, 2019

Copy link
Copy Markdown

Steve Lee (@SteveL-MSFT) FYI. Waiting for PowerShell Committee to review this simple new public API.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jan 30, 2019

Copy link
Copy Markdown
Member

@PowerShell/powershell-committee reviewed this. It should be understood that cmdlets are not considered APIs, so adding a new parameter that is implemented as a public member does not require @PowerShell/powershell-committee review unless the reviewers of the PR believe it is controversial or can not come to a consensus. In this case, -ReplyTo makes sense.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SteveL-MSFT Steve Lee (SteveL-MSFT) added Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Jan 30, 2019
@anmenaga

Andrew (anmenaga) commented Jan 31, 2019

Copy link
Copy Markdown

Exception for the CodeFactor issue seems reasonable. Merging,..

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anmenaga
Andrew (anmenaga) merged commit c935bce into PowerShell:master Jan 31, 2019
@iSazonov

Ilya (iSazonov) commented Jan 31, 2019

Copy link
Copy Markdown
Collaborator

Joshua T (@replicaJunction) Thanks for your contribution!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Feb 1, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@replicaJunction Andrew
Adding parameter "ReplyTo" to Send-MailMessage (PowerShell#8727)
21abe9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@anmenaga Andrew (anmenaga)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@replicaJunction @msftclas @iSazonov @anmenaga @SteveL-MSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.