GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update packaging script to build reference assembly targeting `netcoreapp2.1` and use actual `.csproj` files by daxian-dbw · Pull Request #8729 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Jan 24, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Update packaging script to build reference assembly targeting netcoreapp2.1 and use actual .csproj files.
Fix #8721

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Update script about reference assembly to use actual .csproj files
a029899
@daxian-dbw
Dongbo Wang (daxian-dbw) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Andrew (anmenaga) January 24, 2019 02:44
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from Paul Higinbotham (PaulHigin) as a code owner January 24, 2019 02:44
@daxian-dbw
Make the use of Join-Path compatible to Windows PowerShell
bf1053d
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Jan 24, 2019
View reviewed changes
Comment thread tools/packaging/projects/reference/System.Management.Automation.csproj Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/packaging/projects/reference/System.Management.Automation.csproj Resolved

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Address Aditya's comments
a33c97c
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan) Jan 24, 2019
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 24, 2019
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jan 24, 2019
View reviewed changes
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Jan 24, 2019

Copy link
Copy Markdown
Member Author

Verified by build https://mscodehub.visualstudio.com/PowerShellCore/_build%2Fresults?buildId=72005&_a=summary
Build passed and the generated nuget packages are also manually verified.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 24, 2019

Copy link
Copy Markdown
Member

We may need to tell dependabot to rescan the repo after this is merged.
adityapatwardhan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Jan 24, 2019
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 1264a00 into PowerShell:master Jan 25, 2019
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the refassembly branch January 26, 2019 10:21
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request May 14, 2019
@daxian-dbw @TravisEz13
Update packaging script to build reference assembly targeting `netcor…
f10279e 
…eapp2.1` and use actual `.csproj` files (PowerShell#8729)

# Conflicts:
#	tools/packaging/packaging.psm1
#	tools/packaging/packaging.strings.psd1
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @adityapatwardhan
Update packaging script to build reference assembly targeting `netcor…
5f852cc 
…eapp2.1` and use actual `.csproj` files (PowerShell#8729)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Check in the .csproj files that are used to build reference assemblies for our SDK nuget packages

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@daxian-dbw @TravisEz13 @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.