GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Refactor `appveyor.psm1` to `ci.psm1` by RDIL · Pull Request #8733 · PowerShell/PowerShell

Conversation

@RDIL

@RDIL Reece Dunham (RDIL) commented Jan 24, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

AppVeyor removed, so file has been renamed, as well as many AppVeyor references / env vars / etc. have been removed.

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: [docs] [code] AppVeyor/Travis CI references exist #8686
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13 and RDIL reacted with hooray emoji
All reactions
  • 🎉 2 reactions
@RDIL
Refactor appveyor.psm1 to ci.psm1
000053b
@RDIL
Reece Dunham (RDIL) requested review from Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners January 24, 2019 14:07
Reece Dunham (RDIL) added 3 commits January 24, 2019 09:09
@RDIL
[feature] trigger extra tests
f2fc60e
@RDIL
Update ci.psm1
7e5e141
@RDIL
[feature] fix tests
092bdb4
TravisEz13
Travis Plunk (TravisEz13) requested changes Jan 24, 2019
View reviewed changes

@TravisEz13 Travis Plunk (TravisEz13) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.

Just one comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tools/ci.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 24, 2019

Copy link
Copy Markdown
Member

This was work we planned. FYI, We also planned on merging travis.ps1 and removing duplicate code (It doesn't need to be done in the same PR).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) self-assigned this Jan 24, 2019
PaulHigin
Paul Higinbotham (PaulHigin) suggested changes Jan 24, 2019
View reviewed changes
Comment thread tools/ci.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Travis Plunk (TravisEz13) and others added 2 commits January 24, 2019 14:39
@TravisEz13 @RDIL
Update tools/ci.psm1
2aaaf0c 
Co-Authored-By: RDIL <[email protected]>
@RDIL
Address feedback
b40661d
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jan 24, 2019
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) approved these changes Jan 24, 2019
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 24, 2019

Copy link
Copy Markdown
Member

Paul Higinbotham (@PaulHigin) Please update your review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Jan 25, 2019

Copy link
Copy Markdown
Contributor Author

Paul Higinbotham (@PaulHigin) I fixed the problems, please re-review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL
Update ci.psm1
de61c49
TravisEz13
Travis Plunk (TravisEz13) approved these changes Jan 25, 2019
View reviewed changes
@RDIL

Reece Dunham (RDIL) commented Jan 25, 2019

Copy link
Copy Markdown
Contributor Author

CLA bot is 🅱️roken
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 25, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

No worries, The CLA bot previously approved this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Jan 25, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Windows build now failing for unknown reason. Looks like a file I haven't touched meaning the failure is not an issue with this PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 25, 2019

Copy link
Copy Markdown
Member

We found a test regressed due to an environmental issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 25, 2019

Copy link
Copy Markdown
Member

merged the fix for the test. I'm going to try to just retry the windows CI. If it fails again with the same error, ask me to rebase the branch with the fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Jan 25, 2019
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 04a31ff into PowerShell:master Jan 25, 2019
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 25, 2019

Copy link
Copy Markdown
Member

Used admin rights to merge. CLA did not run on the last commit, but it approved the commit before that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 25, 2019

Copy link
Copy Markdown
Member

Thanks again Reece Dunham (@RDIL)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL
Reece Dunham (RDIL) deleted the patch-3 branch January 26, 2019 00:03
@iSazonov Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Feb 1, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@RDIL @TravisEz13
Refactor appveyor.psm1 to ci.psm1 (PowerShell#8733)
6d788a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@RDIL @TravisEz13 @adityapatwardhan @PaulHigin @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.