GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve check for developer mode by checking minimum required build number by adityapatwardhan · Pull Request #8749 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Jan 25, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

The test would fail if the developer mode is enabled but the machine has an older build than the minimum required build.
The change adds a check for the build version in the test.

PR Context

The current is causing CI failures.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan
Improve check for developer mode by checking minimum required build n…
961d585 
…umber

The test would fail if the developer mode is enabled but the machine has an older build than the minimum required build.
The change adds a check for the build version in the test.
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) self-assigned this Jan 25, 2019
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Steve Lee (SteveL-MSFT) January 25, 2019 19:52
JamesWTruher
James Truher (JamesWTruher) approved these changes Jan 25, 2019
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't blocking, but it might be easier to read/maintain

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/New-Item.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
James Truher (JamesWTruher) and others added 2 commits January 25, 2019 12:08
@JamesWTruher @adityapatwardhan
Update test/powershell/Modules/Microsoft.PowerShell.Management/New-It…
9bd7dec 
…em.Tests.ps1

Co-Authored-By: adityapatwardhan <[email protected]>
@adityapatwardhan
Fix check in product so 10.1.0 OSVersion does not fail to add the flag
2caa9c2
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Bruce Payette (BrucePay) and Andrew (anmenaga) as code owners January 25, 2019 20:30
JamesWTruher
James Truher (JamesWTruher) reviewed Jan 25, 2019
View reviewed changes
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) commented Jan 25, 2019
View reviewed changes
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Update src/System.Management.Automation/namespaces/FileSystemProvider.cs
c7c4f98 
Better performance
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) commented Jan 25, 2019
View reviewed changes
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Update src/System.Management.Automation/namespaces/FileSystemProvider.cs
1d9050a 
Fix spacing around `,`
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Jan 25, 2019
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) approved these changes Jan 25, 2019
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 25, 2019

Copy link
Copy Markdown
Member

merging this because it is blocking PRs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) merged commit 6ccbebd into PowerShell:master Jan 25, 2019
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the FixSymLinkTest branch January 25, 2019 23:46
@iSazonov Ilya (iSazonov) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Feb 1, 2019
@powercode

Staffan Gustafsson (powercode) commented Feb 6, 2019

Copy link
Copy Markdown
Collaborator

Aditya Patwardhan (@adityapatwardhan) I'm a bit late to the party here, but I noticed that we are depending a manifest in the binary for OSVersion to give correct results. This doesn't seem to happen when we run the tests, as they are loaded into the dotnet.exe binary. I get version 6.2 on my windows 10 machine when running the tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Feb 6, 2019

Copy link
Copy Markdown
Member

Staffan Gustafsson (@powercode) Windows API, by default, will return 6.2 for the Windows Version. For Windows PowerShell and PowerShell Core, we rely on a compatibility section in the app manifest to have it return 10. If you're referring to unit tests running in dotnet.exe, it may be ok to expect 6.2 as long as it's understood.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@powercode

Staffan Gustafsson (powercode) commented Feb 7, 2019

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) It's just annoying when the tests don't behave as the product.
Maybe the right thing to do to get dotnet.exe to have a manifest too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan @TravisEz13
Improve check for developer mode by checking minimum required build n…
f6d2672 
…umber (PowerShell#8749)

* Improve check for developer mode by checking minimum required build number

The test would fail if the developer mode is enabled but the machine has an older build than the minimum required build.
The change adds a check for the build version in the test.

* Update test/powershell/Modules/Microsoft.PowerShell.Management/New-Item.Tests.ps1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
+1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@adityapatwardhan @TravisEz13 @powercode @SteveL-MSFT @JamesWTruher @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.