GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove appveyor functions from New-DockerTestBuild.psm1 by RDIL · Pull Request #8756 · PowerShell/PowerShell

Conversation

@RDIL

@RDIL Reece Dunham (RDIL) commented Jan 27, 2019

Copy link
Copy Markdown
Contributor

PR Summary

Remove interactions to appveyor api in this file

PR Context

#8686

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: [docs] [code] AppVeyor/Travis CI references exist #8686
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RDIL
Remove appveyor functions from New-DockerTestBuild.psm1
7b02ac3
@RDIL
Reece Dunham (RDIL) requested review from Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners January 27, 2019 17:46
@RDIL
[feature] trigger feature tests
2911b77
@TravisEz13 Travis Plunk (TravisEz13) assigned Andrew (anmenaga) Jan 28, 2019
@TravisEz13

Travis Plunk (TravisEz13) commented Jan 28, 2019

Copy link
Copy Markdown
Member

James Truher (@JamesWTruher) Do you want to do anything with this code before it is removed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL
[feature] fix cmdlet
1bffc74
@JamesWTruher

James Truher (JamesWTruher) commented Jan 31, 2019

Copy link
Copy Markdown
Collaborator

Travis Plunk (@TravisEz13) nothing is ever gone in github :) if we're not using it, we should pull it. I can always get it if the need arises (and start using AppVeyor again)
TravisEz13 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anmenaga
Andrew (anmenaga) approved these changes Jan 31, 2019
View reviewed changes
@anmenaga
Andrew (anmenaga) merged commit 9e4e50a into PowerShell:master Jan 31, 2019
@RDIL
Reece Dunham (RDIL) deleted the patch-3 branch January 31, 2019 19:15
@anmenaga Andrew (anmenaga) added WG-Quality-Test issues in a test or in test infrastructure WG-Maintainers-Build specific to affecting the build labels Jan 31, 2019
@iSazonov Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Feb 1, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@RDIL Andrew
Remove appveyor functions from New-DockerTestBuild.psm1 (PowerShell#8756
2e8a322 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
1 more reviewer
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@anmenaga Andrew (anmenaga)

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log WG-Maintainers-Build specific to affecting the build WG-Quality-Test issues in a test or in test infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@RDIL @TravisEz13 @JamesWTruher @anmenaga @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.