GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update the universal build with framework dependent package for dotnet sdk by adityapatwardhan · Pull Request #8773 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Jan 29, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Update the universal build to also build the framework package needed for the dotnet sdk container image.

PR Context

We build the package in individual builds. This change brings over the steps in the universal build.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Aditya Patwardhan (adityapatwardhan) added 8 commits January 25, 2019 16:55
@adityapatwardhan
Improve packaging script by adding a DestinationPath parameter
2a09d9a
@adityapatwardhan
Add yml for publishing dotnetsdk-fxdependent package
b64f341
@adityapatwardhan
Change blob name to version-internal
66a5c8c
@adityapatwardhan
Fix yml error
2fdd79e
@adityapatwardhan
Move upload to Azure to a separate task
07f7803
@adityapatwardhan
Fix typo
7abaecf
@adityapatwardhan
Add tasks to set ReleaseTagVar and Azure container name
148711e
@adityapatwardhan
Fix release location and download task
8551a14
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) assigned Travis Plunk (TravisEz13) Jan 29, 2019
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Travis Plunk (TravisEz13) January 29, 2019 00:46
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Paul Higinbotham (PaulHigin), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners January 29, 2019 00:46
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 29, 2019

Copy link
Copy Markdown
Member Author

The changes were verified using a private branch on AzDevOps.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) reviewed Jan 29, 2019
View reviewed changes
Comment thread tools/releaseBuild/azureDevOps/templates/dotnetsdk-fxdependent.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) reviewed Jan 29, 2019
View reviewed changes
Comment thread tools/packaging/packaging.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) reviewed Jan 29, 2019
View reviewed changes
Comment thread tools/packaging/packaging.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Jan 29, 2019
View reviewed changes
@adityapatwardhan
Address Travis's feedback
fc452d0
TravisEz13
Travis Plunk (TravisEz13) approved these changes Jan 29, 2019
View reviewed changes
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Jan 29, 2019
View reviewed changes
@TravisEz13 Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 29, 2019
@TravisEz13
Travis Plunk (TravisEz13) merged commit 53c76d1 into PowerShell:master Jan 29, 2019
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the BuildUpdates branch February 11, 2019 17:10
Travis Plunk (TravisEz13) added a commit to TravisEz13/PowerShell that referenced this pull request May 14, 2019
@TravisEz13
Update the universal build with framework dependent package for dotne…
74c225f 
…t sdk (PowerShell#8773)

Update the universal build to also build the framework package needed for the dotnet sdk container image.

## PR Context

We build the package in individual builds. This change brings over the steps in the universal build.

# Conflicts:
#	tools/packaging/packaging.psm1
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan @TravisEz13
Update the universal build with framework dependent package for dotne…
b5082d7 
…t sdk (PowerShell#8773)

Update the universal build to also build the framework package needed for the dotnet sdk container image.

## PR Context  

We build the package in individual builds. This change brings over the steps in the universal build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@adityapatwardhan @TravisEz13 @PaulHigin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.