GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix daily CI builds to publish tar package as artifacts by adityapatwardhan · Pull Request #8775 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Jan 29, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Update the packaging script to always create the tar.gz packages.

PR Context

Daily builds for Linux and MacOS do not publish tar.gz package.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Travis Plunk (TravisEz13) January 29, 2019 01:47
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Paul Higinbotham (PaulHigin), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners January 29, 2019 01:47
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) force-pushed the FixDailyBuildArtifacts branch from 2e7b0fd to 7a5a4cd Compare February 1, 2019 19:50
@adityapatwardhan
Publish tar.gz and TestPackage.zip on daily build
f71b555 
* Also restructured Windows daily build artifacts
* Enabled publishing artifacts on PRs.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) force-pushed the FixDailyBuildArtifacts branch from 7a5a4cd to f71b555 Compare February 1, 2019 22:37
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title WIP: Fix daily CI builds to publish tar package as artifacts Fix daily CI builds to publish tar package as artifacts Feb 1, 2019
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Feb 4, 2019

Copy link
Copy Markdown
Member Author

Travis Plunk (@TravisEz13) This is ready for review and merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Feb 4, 2019
Refactor of travis.ps1 into ci.psm1 #8822
Merged
10 of 11 tasks
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Feb 4, 2019
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) approved these changes Feb 4, 2019
View reviewed changes
Comment thread tools/packaging/packaging.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/packaging/packaging.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Address Travis's feedback
4e4ff95
TravisEz13
Travis Plunk (TravisEz13) approved these changes Feb 4, 2019
View reviewed changes
@TravisEz13 Travis Plunk (TravisEz13) self-assigned this Feb 4, 2019
@TravisEz13
Travis Plunk (TravisEz13) merged commit ec12f37 into PowerShell:master Feb 4, 2019
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the FixDailyBuildArtifacts branch February 4, 2019 22:55
@iSazonov Ilya (iSazonov) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 8, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan @TravisEz13
Fix daily CI builds to publish tar package as artifacts (PowerShell#8775
15ce3cf 
)

Update the packaging script to always create the tar.gz packages.

## PR Context  

Daily builds for Linux and MacOS do not publish tar.gz package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@adityapatwardhan @TravisEz13 @PaulHigin @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.