GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Change xUnit RunspaceTests to run sequentially by PaulHigin · Pull Request #8796 · PowerShell/PowerShell

Conversation

@PaulHigin

@PaulHigin Paul Higinbotham (PaulHigin) commented Jan 30, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

XUnit parallel runspace tests are failing with obscure errors. This appears to be due to parallelism and the tests appear to pass when run serially. This change is to convert the RunspaceTests to Sequential operation

PR Context

These tests have been failing fairly consistently if randomly in our daily builds, and appear to be due to running them in parallel.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@PaulHigin
Temporarily skipping randomly failing test
5ea5781
@PaulHigin Paul Higinbotham (PaulHigin) assigned Aditya Patwardhan (adityapatwardhan) Jan 30, 2019
@PaulHigin
Paul Higinbotham (PaulHigin) requested a review from Aditya Patwardhan (adityapatwardhan) January 30, 2019 17:24
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jan 30, 2019
View reviewed changes
@PaulHigin Paul Higinbotham (PaulHigin) mentioned this pull request Jan 30, 2019
Parallel Xunit tests seems to have a race condition causing random failures #8715
Closed
@iSazonov

Ilya (iSazonov) commented Jan 30, 2019

Copy link
Copy Markdown
Collaborator

If we turn off this test we will never fix the race condition which is very bad for real world scenarios. I suggest to review and merge #8779 that will eliminate inter-thread race conditions. Then we could think more about inter-process race conditions. I already look this and couldl push a PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 30, 2019

Copy link
Copy Markdown
Member

Paul Higinbotham (@PaulHigin) Could you look at the xUnit failure?
Also put a description and context in the PR description
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@PaulHigin

Paul Higinbotham (PaulHigin) commented Jan 30, 2019

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) Ilya (@iSazonov) The tests are still failing (but in a different test), and in the same way (malformed file path). So I will re-enable the test and try running as sequential instead of parallel, to verify this is indeed a race condition.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@PaulHigin
re-enable previous test. Try running as tests as sequential.
9ad346c
@PaulHigin Paul Higinbotham (PaulHigin) changed the title Temporarily skipping randomly failing test WIP Temporarily skipping randomly failing test Jan 30, 2019
@PaulHigin
[Feature]
fe1f31b
@PaulHigin Paul Higinbotham (PaulHigin) changed the title WIP Temporarily skipping randomly failing test Change xUnit RunspaceTests to run sequentially Jan 30, 2019
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 30, 2019

Copy link
Copy Markdown
Member

Not waiting the recommended 24 hours since this is blocking PRs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit f3efcab into PowerShell:master Jan 30, 2019
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 30, 2019
@PaulHigin
Paul Higinbotham (PaulHigin) deleted the skip-parallel-runspacetest branch January 30, 2019 23:00
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@PaulHigin @adityapatwardhan
Change xUnit RunspaceTests to run sequentially (PowerShell#8796)
c5be91d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@PaulHigin @iSazonov @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.