GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add compliance to Coordinated build by TravisEz13 · Pull Request #8798 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Jan 30, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Add compliance to Coordinated build

  • Also switch to mac internal pool for release build
  • Also turn some duplicate tasks into templates
  • Also fix issue with vscode configuration which causes yaml files not to be recogized as yaml

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Travis Plunk (TravisEz13) added 10 commits January 29, 2019 11:10
@TravisEz13
switch to mac internal pool
0fa8d11
@TravisEz13
call compliance template
dc8b4d5
@TravisEz13
Add compliance template
a6bdb0c
@TravisEz13
add a step template
994116a
@TravisEz13
Add nuget update to CG build
ca26ee0
@TravisEz13
remove public
7f281b7
@TravisEz13
add template to upload windows packages
9a539ef
@TravisEz13
use template to upload windows packages
4450ee4
@TravisEz13
add uml and diagram of build
4b08975
@TravisEz13
remove azure-pipeline as a file association (some people don't like it)
a6058df 
and add it as a recommended extension
@TravisEz13
Travis Plunk (TravisEz13) requested review from Paul Higinbotham (PaulHigin), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners January 30, 2019 18:58
@TravisEz13
fix reuse of an alias
e5571bb 
add comments
Add a finish task and map all the leafs to it
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the add_compliance_gh branch from 9906ecf to e5571bb Compare January 30, 2019 20:54
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Jan 30, 2019
View reviewed changes
Comment thread tools/releaseBuild/azureDevOps/templates/compliance.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/releaseBuild/azureDevOps/templates/compliance.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/releaseBuild/azureDevOps/releaseBuild.yml
- template: templates/compliance.yml
parameters:
parentJobs:
- build_windows_x64

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Jan 30, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also wait for Linux and macOS builds for running antivirus?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jan 30, 2019
View reviewed changes
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 30, 2019

Copy link
Copy Markdown
Member

All comments are non-blocking but should be fixed eventually.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) merged commit a872b8d into PowerShell:master Jan 30, 2019
@TravisEz13
Travis Plunk (TravisEz13) deleted the add_compliance_gh branch January 30, 2019 22:10
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Feb 1, 2019
@iSazonov Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Feb 1, 2019
@TravisEz13 Travis Plunk (TravisEz13) added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log and removed CL-Tools Indicates that a PR should be marked as a tools change in the Change Log labels Feb 2, 2019
Travis Plunk (TravisEz13) added a commit to TravisEz13/PowerShell that referenced this pull request May 14, 2019
@TravisEz13
Add compliance to Coordinated build (PowerShell#8798)
d3f3e9f 
Add compliance to Coordinated build
  - Also switch to mac internal pool for release build
  - Also turn some duplicate tasks into templates
  - Also fix issue with vscode configuration which causes yaml files not to be recogized as yaml
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Add compliance to Coordinated build (PowerShell#8798)
9e44e72 
Add compliance to Coordinated build
  - Also switch to mac internal pool for release build
  - Also turn some duplicate tasks into templates
  - Also fix issue with vscode configuration which causes yaml files not to be recogized as yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@TravisEz13 @adityapatwardhan @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.