GeezerVison

PR Summary

Make the suggestion on a CommandNotFoundException an ExperimentalFeature.

PR Context

The current design of suggestions is closely tied to the host (ConsoleHost in this case). The ConsoleHost checks if there was anything from the last command and initiates an evaluation of suggestions. The evaluation of suggestions checks if the last command failed by looking at $?. If so, then it applies each suggestion. In the case of CommandNotFound, this is based on looking at the ErrorRecord at $Error[0] which is one problem with the suggestion framework as it only looks at the most recent error. If found, it applies this new suggestion and it outputs the possible commands. The problem is if a script is run in the command line (or part of a pipeline), and the ErrorAction is SilentlyContinue, the error still shows up in $Error so the suggestion applies, but because you don't see the non-terminating error message, you have no context of how the suggestion applies.

A proper fix is much more complicated as it requires redesigning the suggestion framework:

• Currently, suggestions are initiated by the host (consolehost in this case) and should be part of the ErrorRecord so that it works correctly remotely and in other hosts
• ErrorRecord has a member called RecommendedAction that should contain the suggestion
• The code to invoke getting suggestions needs to be moved out of consolehost and closer to where the ErrorRecord is created
• Formatter for ErrorRecord needs to be updated to show the RecommendedAction member
• Suggestions should be in its own stream or Information stream rather than written directly to the host

Temporary resolution to #8793

No test added/modified as suggestions are currently written directly to the host.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Change is not breaking
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
    • Add [feature] to your commit messages if the change is significant or affects feature tests