GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tab completion test doesn't handle multiple matches by JamesWTruher · Pull Request #8891 · PowerShell/PowerShell

Conversation

@JamesWTruher

@JamesWTruher James Truher (JamesWTruher) commented Feb 13, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Some environments have multiple matches, so some TabCompletion tests may fail because of an assumption that there is only 1 possible match. I'm seeing this specifically on the Linux container validation runs, but it seems like it would be general problem.

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher
[feature] Some environment may have additional environment variables …
0a203ee 
…defined, harden the test to handle multiple matches
@JamesWTruher James Truher (JamesWTruher) added the WG-Quality-Test issues in a test or in test infrastructure label Feb 13, 2019
@JamesWTruher
James Truher (JamesWTruher) requested a review from Aditya Patwardhan (adityapatwardhan) February 13, 2019 21:00
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Feb 13, 2019
View reviewed changes
iSazonov
Ilya (iSazonov) reviewed Feb 14, 2019
View reviewed changes
Comment thread test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1
$res = TabExpansion2 -inputScript $inputStr -cursorColumn $inputStr.Length
$res.CompletionMatches.Count | Should -BeGreaterThan 0
$res.CompletionMatches[0].CompletionText | Should -BeExactly $expected
$res.CompletionMatches.CompletionText | Should -Contain $expected

@iSazonov Ilya (iSazonov) Feb 14, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is order/position important in the test?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov Ilya (iSazonov) added CL-Test Indicates that a PR should be marked as a test change in the Change Log and removed WG-Quality-Test issues in a test or in test infrastructure labels Feb 14, 2019
@iSazonov

Ilya (iSazonov) commented Mar 8, 2019

Copy link
Copy Markdown
Collaborator

Is the PR ready to merge?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw Dongbo Wang (daxian-dbw) added this to the 6.2.0 milestone Mar 11, 2019
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit e605fbd into PowerShell:master Mar 11, 2019
@iSazonov

Ilya (iSazonov) commented Mar 12, 2019

Copy link
Copy Markdown
Collaborator

Dongbo Wang (@daxian-dbw) Please clarify about setting a milestone to merged PR. Is there new guidelines?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Mar 12, 2019

Copy link
Copy Markdown
Member

After RC release, we created the v6.2.0 branch, which will be the branch to use for 6.2.0 GA release.
Not all commits after RC can make to the GA, so we will triage what PRs can be take to the 6.2.0 branch (very low risk, no product code change in principle). For those PRs that will be take to 6.2.0 branch, we mark it with the 6.2.0 milestone.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Mar 13, 2019
@JamesWTruher @TravisEz13
Fix tab completion test to handle multiple matches (#8891)
f80a005
@iSazonov Ilya (iSazonov) assigned Dongbo Wang (daxian-dbw) Apr 3, 2019
@JamesWTruher
James Truher (JamesWTruher) deleted the tabcompletiontestfix01 branch September 23, 2023 05:34
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@JamesWTruher @daxian-dbw
Fix tab completion test to handle multiple matches (PowerShell#8891)
d434792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

6.2.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JamesWTruher @iSazonov @daxian-dbw @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.