GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Change label in doc issue template by iSazonov · Pull Request #8895 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Feb 14, 2019 •
edited by TravisEz13
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

CL-* is used only for ChangeLog automation.

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov Ilya (iSazonov) added the CL-Untagged label Feb 14, 2019
@iSazonov
Ilya (iSazonov) requested review from Travis Plunk (TravisEz13) and Joey Aiello (joeyaiello) as code owners February 14, 2019 14:51
@iSazonov
Ilya (iSazonov) requested a review from Steve Lee (SteveL-MSFT) February 14, 2019 14:51
RDIL
Reece Dunham (RDIL) reviewed Feb 14, 2019
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/Documentation_Issue.md Outdated

@RDIL Reece Dunham (RDIL) Feb 14, 2019

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but I think this might need to be an array or just 1 label.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vexx32 Rain Sallow (/u/ta11ow) (vexx32) Feb 14, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I remember the syntax right this needs to look more like this:

Suggested change
labels: Issue-Question,Area-Documentation
labels: [Issue-Question, Area-Documentation]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Feb 14, 2019

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working sample https://raw.githubusercontent.com/lee-dohm/test-repo/master/.github/ISSUE_TEMPLATE/Bug_report.md

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov Ilya (iSazonov) changed the title Change label in doc issue teplate Change label in doc issue template Feb 14, 2019
@iSazonov

Ilya (iSazonov) commented Feb 26, 2019

Copy link
Copy Markdown
Collaborator Author

Travis Plunk (@TravisEz13) Can we merge the template update?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) added CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log and removed CL-Untagged labels Feb 26, 2019
@TravisEz13

Travis Plunk (TravisEz13) commented Feb 26, 2019

Copy link
Copy Markdown
Member

restarted the windows CI. Ping me if it passes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Feb 26, 2019

Copy link
Copy Markdown
Contributor

It failed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vexx32

Rain Sallow (/u/ta11ow) (vexx32) commented Feb 26, 2019

Copy link
Copy Markdown
Collaborator

Weren't there a couple PRs to remove appveyor refs from the build? Error is:

Invoke-AppveyorInstall : The term 'Invoke-AppveyorInstall' is not recognized as the name of a cmdlet, function, script 
file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct 
and try again.

Maybe try fast forwarding your branch to latest master?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Feb 26, 2019

Copy link
Copy Markdown
Contributor

Yeah, that would be the set of PRs I opened. Rebasing (should) fix it
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov
Change label in doc issue teplate
638ad60
@iSazonov
Ilya (iSazonov) force-pushed the issue-template-doc branch from 2a05416 to 638ad60 Compare February 26, 2019 20:02
@iSazonov

Ilya (iSazonov) commented Feb 26, 2019

Copy link
Copy Markdown
Collaborator Author

Rebased.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Feb 26, 2019
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 31699be into PowerShell:master Feb 26, 2019
@iSazonov
Ilya (iSazonov) deleted the issue-template-doc branch February 27, 2019 03:35
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Apr 3, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov @TravisEz13
Change label in doc issue template (PowerShell#8895)
2c7893f 
CL-* is used only for ChangeLog automation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@joeyaiello Joey Aiello (joeyaiello) Awaiting requested review from joeyaiello
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
+2 more reviewers
@vexx32 Rain Sallow (/u/ta11ow) (vexx32) vexx32 left review comments
@RDIL Reece Dunham (RDIL) RDIL left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iSazonov @TravisEz13 @RDIL @vexx32
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.