GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Markdown lint issues by TravisEz13 · Pull Request #8929 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Feb 20, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

#8896 Broke the static analysis CI. Reverting so this does not block PRs.

I think the line you fixed was an syntax error which was hiding other issues.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Travis Plunk (TravisEz13) added 2 commits February 20, 2019 13:01
@TravisEz13
remove some of the checks
0f40075
@TravisEz13
fix some issues
f349f2d
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the revert-8896-patch-3 branch from 62f9a95 to f349f2d Compare February 20, 2019 21:02
@TravisEz13
Travis Plunk (TravisEz13) requested a review from Joey Aiello (joeyaiello) as a code owner February 20, 2019 21:02
@TravisEz13
hopefully fix the last of the issues
6835df8
@TravisEz13 Travis Plunk (TravisEz13) changed the title Revert "Fix code-of-conduct linting" Fix Markdown lint issues Feb 20, 2019
RDIL
Reece Dunham (RDIL) approved these changes Feb 20, 2019
View reviewed changes

@RDIL Reece Dunham (RDIL) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, sorry.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13

Travis Plunk (TravisEz13) commented Feb 20, 2019

Copy link
Copy Markdown
Member Author

Reece Dunham (@RDIL) Things happen...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Feb 20, 2019

Copy link
Copy Markdown
Member Author

And technically, my code has a bug which is swallowing the syntax error. I'll fix that at some point.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Feb 20, 2019
remove double blanks to adhere to markdown lint #8927
Closed
7 of 11 tasks
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Feb 20, 2019
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 2c488fb into master Feb 20, 2019
@TravisEz13
Travis Plunk (TravisEz13) deleted the revert-8896-patch-3 branch February 20, 2019 21:24
@TravisEz13 Travis Plunk (TravisEz13) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Feb 27, 2019
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Apr 3, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Fix Markdown lint issues (PowerShell#8929)
4a2b6fe 
PowerShell#8896 Broke the static analysis CI.  Fixing so CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@joeyaiello Joey Aiello (joeyaiello) Awaiting requested review from joeyaiello
+1 more reviewer
@RDIL Reece Dunham (RDIL) RDIL approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@TravisEz13 @adityapatwardhan @RDIL
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.