GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Integrate building NuGet package in the coordinated build by adityapatwardhan · Pull Request #8947 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Feb 21, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Integrate building the nuget package in the coordinated build.
It releases the signed nuget packages as build artifacts

PR Context

The nuget packaging is dependent on artifacts generated by the coordinated build. Hence, generation on NuGet packages is integrated into the coordinated build.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Aditya Patwardhan (adityapatwardhan) added 2 commits February 21, 2019 13:47
@adityapatwardhan
Parameterize update table step
b57c6c7
@adityapatwardhan
Integrated nuget packaging and signing in coordinated build
011883f
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Travis Plunk (TravisEz13) February 21, 2019 22:47
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Paul Higinbotham (PaulHigin), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners February 21, 2019 22:47
TravisEz13
Travis Plunk (TravisEz13) reviewed Feb 21, 2019
View reviewed changes
Comment thread tools/releaseBuild/azureDevOps/templates/nuget.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) reviewed Feb 21, 2019
View reviewed changes
Comment thread tools/releaseBuild/azureDevOps/templates/updateBuildTable.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Aditya Patwardhan (adityapatwardhan) added 10 commits February 21, 2019 14:56
@adityapatwardhan
Remove updateTable.yml and update machine pool
78c5c00
@adityapatwardhan
Fix quotes around Azure DevOps variables and added step to verify nug…
d2828ad 
…et signing
@adityapatwardhan
Set Version variable
f6ba85e
@adityapatwardhan
Install nuget.exe
0e407f4
@adityapatwardhan
Fix script and update nuget version
efef01d
@adityapatwardhan
Fix script
b12e383
@adityapatwardhan
Fix signing file path
a86c168
@adityapatwardhan
Fix typo
923f979
@adityapatwardhan
Fix typo
af50223
@adityapatwardhan
Fix typo in Build.SourcesDirectory
c3153a1
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Travis Plunk (TravisEz13) February 22, 2019 22:45
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title WIP - Integrate building NuGet package in the coordinated build Integrate building NuGet package in the coordinated build Feb 22, 2019
TravisEz13
Travis Plunk (TravisEz13) approved these changes Feb 23, 2019
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 81d37fc into PowerShell:master Feb 25, 2019
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the PortNugetBuild branch February 25, 2019 17:57
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 25, 2019
@iSazonov Ilya (iSazonov) assigned Aditya Patwardhan (adityapatwardhan) Apr 3, 2019
Aditya Patwardhan (adityapatwardhan) added a commit to adityapatwardhan/PowerShell that referenced this pull request May 23, 2019
@adityapatwardhan
Integrate building NuGet package in the coordinated build (PowerShell…
c97436b 
…#8947)
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request May 23, 2019
@adityapatwardhan @TravisEz13
Integrate building NuGet package in the coordinated build (#8947) (#9708
4cd3850 
)
@ghost

Deleted user (ghost) commented Jul 16, 2019

Copy link
Copy Markdown

🎉v6.1.5 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
TravisEz13 reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Integrate building NuGet package in the coordinated build (PowerShell…
5d80793 
…#8947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@adityapatwardhan @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.