GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Added RequireSudoOnUnix tags to PowerShellGet tests and unmark as pending by RDIL · Pull Request #8954 · PowerShell/PowerShell

Conversation

@RDIL

@RDIL Reece Dunham (RDIL) commented Feb 22, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Enables the test with the new tag, unmark as pending

PR Context

Enables the check by adding RequireSudoOnUnix tag to Describe block

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RDIL
Update comments in PowerShellGet tests for Travis CI
a2c9455
markekraus
Mark Kraus (markekraus) approved these changes Feb 22, 2019
View reviewed changes

@markekraus Mark Kraus (markekraus) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RDIL reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
iSazonov
Ilya (iSazonov) approved these changes Feb 22, 2019
View reviewed changes
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) reviewed Feb 25, 2019
View reviewed changes
Comment thread test/powershell/Modules/PowerShellGet/PowerShellGet.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Reece Dunham (RDIL) added 2 commits February 25, 2019 13:05
@RDIL
Update PowerShellGet.Tests.ps1
cb9fc8c
@RDIL
[feature]
3cadc25
@RDIL

Reece Dunham (RDIL) commented Feb 25, 2019

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) Ilya (@iSazonov) please re-review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL Reece Dunham (RDIL) changed the title Update comments in PowerShellGet tests for Travis CI Enabled some PowerShellGet tests that now work on Linux Feb 25, 2019
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Feb 25, 2019
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Feb 25, 2019

Copy link
Copy Markdown
Collaborator

Reece Dunham (@RDIL) Please look CI-Linux errors.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Feb 25, 2019

Copy link
Copy Markdown
Contributor Author

I guess the comment is still right
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL Reece Dunham (RDIL) changed the title Enabled some PowerShellGet tests that now work on Linux Updated comments from TravisCI -> Azure DevOps in PowerShellGet Linux tests Feb 25, 2019
@iSazonov

Ilya (iSazonov) commented Feb 25, 2019

Copy link
Copy Markdown
Collaborator

Yes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Feb 25, 2019

Copy link
Copy Markdown
Member

Reece Dunham (@RDIL) Can you add RequireSudoOnUnix tag to both describes?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Reece Dunham (RDIL) added 2 commits February 25, 2019 14:43
@RDIL
Revert
190f9cc
@RDIL
[feature] RequireSudoOnUnix
9b4aa57
@RDIL

Reece Dunham (RDIL) commented Feb 25, 2019

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) I believe I did it, not sure.
(I'm new to PowerShell syntax)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) reviewed Feb 28, 2019
View reviewed changes
Comment thread test/powershell/Modules/PowerShellGet/PowerShellGet.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RDIL
Update PowerShellGet.Tests.ps1
71cd7e1
iSazonov
Ilya (iSazonov) reviewed Feb 28, 2019
View reviewed changes
Comment thread test/powershell/Modules/PowerShellGet/PowerShellGet.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Reece Dunham (RDIL) added 2 commits February 28, 2019 10:56
@RDIL
Fix
15c6042
@RDIL
Fixed tests!
389f53b
iSazonov
Ilya (iSazonov) reviewed Feb 28, 2019
View reviewed changes
Comment thread test/powershell/Modules/PowerShellGet/PowerShellGet.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Reece Dunham (RDIL) added 2 commits February 28, 2019 11:42
@RDIL
Revert
78a9693
@RDIL
Missed one
482d685
@RDIL Reece Dunham (RDIL) changed the title Updated comments from TravisCI -> Azure DevOps in PowerShellGet Linux tests Added RequireSudoOnUnix tags to PowerShellGet tests and unmark as pending Feb 28, 2019
Reece Dunham (RDIL) added 2 commits February 28, 2019 11:44
@RDIL
[feature] empty commit to trigger feature tests
fe89291
@RDIL
Merge remote-tracking branch 'upstream/master' into patch-1
81a64ec
@RDIL

Reece Dunham (RDIL) commented Mar 4, 2019

Copy link
Copy Markdown
Contributor Author

Everything is now fixed, ready for review/merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Mar 4, 2019
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Mar 4, 2019
@iSazonov Ilya (iSazonov) assigned Aditya Patwardhan (adityapatwardhan) Mar 4, 2019
Reece Dunham (RDIL) added 2 commits March 4, 2019 16:32
@RDIL
Add space where it should be
f3d1889
@RDIL
[feature] get cla bot to work (empty commit)
254fa96
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Mar 5, 2019

Copy link
Copy Markdown
Member

Restarted CI for Linux
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Mar 5, 2019

Copy link
Copy Markdown
Contributor Author

Thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Mar 5, 2019

Copy link
Copy Markdown
Member

Reece Dunham (@RDIL) can you update the PR description and context please?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Mar 5, 2019

Copy link
Copy Markdown
Contributor Author

Sure
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Mar 5, 2019

Copy link
Copy Markdown
Contributor Author

Done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit da4930f into PowerShell:master Mar 5, 2019
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Mar 5, 2019

Copy link
Copy Markdown
Member

Reece Dunham (@RDIL) Thank you for your contribution
RDIL reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL
Reece Dunham (RDIL) deleted the patch-1 branch March 5, 2019 19:57
@daxian-dbw Dongbo Wang (daxian-dbw) added this to the 6.2.0 milestone Mar 11, 2019
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Mar 13, 2019
@RDIL @TravisEz13
Added RequireSudoOnUnix tags to PowerShellGet tests and unmark as pen…
a4517c0 
…ding (#8954)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@RDIL @adityapatwardhan
Added RequireSudoOnUnix tags to PowerShellGet tests and unmark as pen…
21730f1 
…ding (PowerShell#8954)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
+1 more reviewer
@markekraus Mark Kraus (markekraus) markekraus approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

6.2.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@RDIL @iSazonov @adityapatwardhan @markekraus @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.