GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Build Global tool for PowerShell and SDK container by adityapatwardhan · Pull Request #8984 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Feb 26, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

This PR builds a unified global tool to support all the runtimes as well as two separate reduced size global tools to be included in dotnet sdk container images.

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Aditya Patwardhan (adityapatwardhan) added 12 commits February 25, 2019 11:21
@adityapatwardhan
Add global tool packages
f08ed32
@adityapatwardhan
Update nuspec
74ef370
@adityapatwardhan
Prototype for pwsh global tool shim
e5004dc
@adityapatwardhan
Progress arguments
4cbbc45
@adityapatwardhan
Add shim dll to redirect to appropriate runtime
df36bc4
@adityapatwardhan
Add logging
e7114bf
@adityapatwardhan
Build updates for creating global tool package
e1076b1
@adityapatwardhan
Add back macOs runtimes
009244b
@adityapatwardhan
Remove code for creating dotnetsdk-fxdependent package
3e33f38
@adityapatwardhan
Add building global tool to nuget.yml
ca2a592
@adityapatwardhan
Reduce package size for dotnet sdk packages only
159e744
@adityapatwardhan
Remove Global tool assembly from signing for regular builds
b25502b
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Travis Plunk (TravisEz13) February 26, 2019 02:06
Aditya Patwardhan (adityapatwardhan) added 8 commits February 25, 2019 18:10
@adityapatwardhan
Fix CodeFactor issues
5d9b567
@adityapatwardhan
Fix typo in yml
ec463bc
@adityapatwardhan
Remove ErrorAction Stop to avoid failure on symlink copy
6c0b025
@adityapatwardhan
Remove symlinks
f09b8d1
@adityapatwardhan
Add symlink cleanup
d370247
@adityapatwardhan
Change download type in yml
b49be49
@adityapatwardhan
Fix file encoding
0b20827
@adityapatwardhan
Add azure upload of nuget packages
b8b7ff6
iSazonov
Ilya (iSazonov) reviewed Feb 26, 2019
View reviewed changes
Comment thread src/Microsoft.PowerShell.GlobalTool.Shim/GlobalToolShim.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/Microsoft.PowerShell.GlobalTool.Shim/runtimeconfig.template.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tools/packaging/packaging.psm1
[Parameter(Mandatory)] $DestinationPath
)
## Remove unnecessary files
$localeFolderToRemove = 'cs', 'de', 'es', 'fr', 'it', 'ja', 'ko', 'pl', 'pt-BR', 'ru', 'tr', 'zh-Hans', 'zh-Hant'

@iSazonov Ilya (iSazonov) Feb 26, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if there will new folder? Maybe not "remove" but "use/filter only necessary folder"?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Feb 26, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I take this as a bug fix after this PR?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Feb 26, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/Microsoft.PowerShell.GlobalTool.Shim/GlobalToolShim.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Address Illya's comments
c99c0c3
TravisEz13
Travis Plunk (TravisEz13) reviewed Feb 26, 2019
View reviewed changes
Comment thread tools/packaging/packaging.strings.psd1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) reviewed Feb 26, 2019
View reviewed changes
Comment thread tools/releaseBuild/azureDevOps/templates/nuget.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Feb 26, 2019
View reviewed changes
@adityapatwardhan
Address Travis's comments
d4326a4
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) marked this pull request as ready for review February 26, 2019 19:16
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners February 26, 2019 19:16
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Paul Higinbotham (PaulHigin) as a code owner February 26, 2019 19:16
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit fb05169 into PowerShell:master Feb 26, 2019
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the FxDependentPkgOptimize branch February 26, 2019 20:56
@iSazonov Ilya (iSazonov) assigned Aditya Patwardhan (adityapatwardhan) Feb 27, 2019
@iSazonov Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Feb 27, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Build Global tool for PowerShell and SDK container (PowerShell#8984)
fbc3bb7 
* Add shim dll to redirect to appropriate runtime
* Build updates for creating global tool package
* Add building global tool to nuget.yml
* Add azure upload of nuget packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@adityapatwardhan @TravisEz13 @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.