GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixed Dockerfile syntax highlighting by RDIL · Pull Request #8991 · PowerShell/PowerShell

Conversation

@RDIL

@RDIL Reece Dunham (RDIL) commented Feb 26, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

The f in Dockerfile is not uppercase, this breaks syntax highlighting for vscode on my client

PR Context

DockerFile breaks syntax highlighting as mentioned and described above.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RDIL
Fixed Dockerfile syntax highlighting
6892b9d
@RDIL
Reece Dunham (RDIL) requested review from Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners February 26, 2019 18:01
Reece Dunham (RDIL) added 2 commits February 26, 2019 13:05
@RDIL
Updated the build.json
01dde44
@RDIL
[feature]
294d1a4
iSazonov
Ilya (iSazonov) approved these changes Feb 26, 2019
View reviewed changes
@RDIL
[feature] rebase to pass CIs
c89ba4f
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Feb 28, 2019
@TravisEz13

Travis Plunk (TravisEz13) commented Feb 28, 2019

Copy link
Copy Markdown
Member

This affects our release build. I'll need to clone the branch into our release build system and verify this does not cause an issue. It will take some time to validate. Please be patient
RDIL reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 28, 2019
@RDIL

Reece Dunham (RDIL) commented Feb 28, 2019

Copy link
Copy Markdown
Contributor Author

Not a problem.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL
Merge remote-tracking branch 'upstream/master' into patch-3
4d30493
@TravisEz13
Travis Plunk (TravisEz13) merged commit d63ac89 into PowerShell:master Mar 11, 2019
@RDIL
Reece Dunham (RDIL) deleted the patch-3 branch March 11, 2019 22:25
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added this to the 6.2.0 milestone Mar 13, 2019
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Mar 13, 2019
@RDIL @TravisEz13
Fixed Dockerfile syntax highlighting (#8991)
722397b 
The `f` in Dockerfile is not uppercase, this breaks syntax highlighting for vscode on my client
<!-- Summarize your PR between here and the checklist. -->

## PR Context
`DockerFile` breaks syntax highlighting as mentioned and described above.
<!-- Provide a little reasoning as to why this Pull Request helps and why you have opened it. -->
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@RDIL @TravisEz13
Fixed Dockerfile syntax highlighting (PowerShell#8991)
e7cc009 
The `f` in Dockerfile is not uppercase, this breaks syntax highlighting for vscode on my client
<!-- Summarize your PR between here and the checklist. -->

## PR Context
`DockerFile` breaks syntax highlighting as mentioned and described above.
<!-- Provide a little reasoning as to why this Pull Request helps and why you have opened it. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

6.2.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@RDIL @TravisEz13 @iSazonov @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.