GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Enter-PSHostProcess tests flakiness by TylerLeonhardt · Pull Request #9007 · PowerShell/PowerShell

Conversation

@TylerLeonhardt

@TylerLeonhardt TylerLeonhardt commented Feb 28, 2019

Copy link
Copy Markdown
Member

PR Summary

This PR totally refactors the Enter-PSHostProcess tests.

fixes #8971

PR Context

The biggest change was that rather then sharing an instance of PowerShell, the tests will each have their own instance of PowerShell to interact with.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TylerLeonhardt
[feature] fix enter-pshostprocess tests
6cb0faa
@TylerLeonhardt

TylerLeonhardt commented Feb 28, 2019

Copy link
Copy Markdown
Member Author

Just to be sure, I'd like to run CI a few times to see if the failure shows up. I'm going to 😴but if someone in some other place (where it's not late) wants to kick them off again by adding commits or something, that'd be helpful!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Feb 28, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

I'd can restart but it is already failed :-(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TylerLeonhardt

TylerLeonhardt commented Feb 28, 2019

Copy link
Copy Markdown
Member Author

Jeez... OK... Ran this like 20 times in a container and couldn't repro the issue.

Back to the drawing board...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TylerLeonhardt

TylerLeonhardt commented Feb 28, 2019

Copy link
Copy Markdown
Member Author

I can repro the same problem if I do this:

> "Enter-PSHostProcess -Id 40328 -ErrorAction Stop
                  `$pid
                  Exit-PSHostProcess" >  test.ps1

> ./test.ps1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Feb 28, 2019

Copy link
Copy Markdown
Collaborator

Looks tricky!
Perhaps James Truher (@JamesWTruher) has ideas how make the tests reliable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TylerLeonhardt

TylerLeonhardt commented Feb 28, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

The odd thing is... I added -ErrorAction Stop to the Enter-PSHostProcess's so this this failure is even more peculiar because $pid should never get run. It should stop executing when Enter-PSHostProcess fails...

"Enter-PSHostProcess -Id $($pwsh.Id) -ErrorAction Stop
`$pid
Exit-PSHostProcess" | pwsh -c - | Should -Be $pwsh.Id
TEST FAILURES
Description: Can enter, exit, and re-enter another PSHost
Name:        Enter-PSHostProcess tests.By Process Id.Can enter, exit, and re-enter another PSHost
message:
Expected 872, but got '1432'.
stack-trace:
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\Enter-PSHostProcess.Tests.ps1: line 47
47:                 Exit-PSHostProcess" | pwsh -c - | Should -Be $pwsh.Id

In my local testing... I noticed that:

Expected 872, but got '1432'.

1432 was typically the $pid of the pwsh that executed Enter-PSHostProcess but that could be a red herring
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Feb 28, 2019

Copy link
Copy Markdown
Collaborator

TylerLeonhardt Maybe #1995?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vexx32

Rain Sallow (/u/ta11ow) (vexx32) commented Feb 28, 2019 •
edited by TylerLeonhardt
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

TylerLeonhardt does this repro the issue?

@'
try {{
    Enter-PSHostProcess -Id {0} -ErrorAction Stop
    $pid
}}
finally {{
    Exit-PSHostProcess
}}
'@ -f $pwsh.Id | pwsh -c - | Should -Be $pwsh.Id

In other words, is the -ErrorAction Stop behaving as we expect?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RDIL
Reece Dunham (RDIL) reviewed Feb 28, 2019
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Enter-PSHostProcess.Tests.ps1 Outdated

It "Should throw if CustomPipeName is too long on Linux or macOS" {
It "Should throw if CustomPipeName is too long on Linux or macOS" -Skip:($IsWindows) {
$longPipeName = "DoggoipsumwaggywagssmolborkingdoggowithalongsnootforpatsdoingmeafrightenporgoYapperporgolongwatershoobcloudsbigolpupperlengthboy"

@RDIL Reece Dunham (RDIL) Feb 28, 2019

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a thing?
(just wondering)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TylerLeonhardt TylerLeonhardt Feb 28, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because on unix they're not called "Named Pipes" they're called "UNIX domain sockets" which have a limit on macOS and Linux.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@RDIL Reece Dunham (RDIL) Feb 28, 2019

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant $longPipeName = "DoggoipsumwaggywagssmolborkingdoggowithalongsnootforpatsdoingmeafrightenporgoYapperporgolongwatershoobcloudsbigolpupperlengthboy"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Feb 28, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to generate needed length and add a comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@RDIL Reece Dunham (RDIL) Feb 28, 2019

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TylerLeonhardt

TylerLeonhardt commented Feb 28, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) Maybe... but I had 100% success rate from 20 runs on my mac and in an ubuntu container.

Rain Sallow (/u/ta11ow) (@vexx32) I'm open to give that a try... the test should still fail, but maybe we'll get more info as to why (also edited your comment to escape the {})
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Feb 28, 2019

Copy link
Copy Markdown
Collaborator

TylerLeonhardt I suggest replace "-c" with "-file" to avoid escaping problem.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TylerLeonhardt
get more info
63fba3c
iSazonov
Ilya (iSazonov) reviewed Feb 28, 2019
View reviewed changes
Comment thread test.ps1 Outdated
@@ -0,0 +1,3 @@
Enter-PSHostProcess -Id 40328 -ErrorAction Stop
$pid
Exit-PSHostProcess

@iSazonov Ilya (iSazonov) Feb 28, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TylerLeonhardt TylerLeonhardt Feb 28, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do. Still getting data. moved to WIP

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TylerLeonhardt TylerLeonhardt changed the title Fix Enter-PSHostProcess tests flakiness WIP: Fix Enter-PSHostProcess tests flakiness Feb 28, 2019
@TylerLeonhardt
write the errors
f7de624
@TylerLeonhardt

TylerLeonhardt commented Feb 28, 2019

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov)

I suggest replace "-c" with "-file" to avoid escaping problem.

Sorry, where exactly?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vexx32
Rain Sallow (/u/ta11ow) (vexx32) reviewed Feb 28, 2019
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Enter-PSHostProcess.Tests.ps1 Outdated
}}
finally {{
Exit-PSHostProcess
}}

@vexx32 Rain Sallow (/u/ta11ow) (vexx32) Feb 28, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double braces?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TylerLeonhardt TylerLeonhardt Feb 28, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need this for template strings to escape { and } otherwise it throws a bad formatting exception

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vexx32 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@TylerLeonhardt

TylerLeonhardt commented Feb 28, 2019

Copy link
Copy Markdown
Member Author

jeez...

Description: Can enter, exit, and re-enter another PSHost
Name:        Enter-PSHostProcess tests.By Process Id.Can enter, exit, and re-enter another PSHost
message:
Expected 4564, but got $null.
stack-trace:
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\Enter-PSHostProcess.Tests.ps1: line 56
56: '@ -f $pwsh.Id | pwsh -c - | Should -Be $pwsh.Id
Description: Can enter and exit another Windows PowerShell PSHost
Name:        Enter-PSHostProcess tests.By Process Id.Can enter and exit another Windows PowerShell PSHost
message:
Expected 3752, but got $null.
stack-trace:
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\Enter-PSHostProcess.Tests.ps1: line 93
93: '@ -f $powershell.Id | pwsh -c - | Should -Be $powershell.Id
Description: Can enter, exit, and re-enter using CustomPipeName
Name:        Enter-PSHostProcess tests.By CustomPipeName.Can enter, exit, and re-enter using CustomPipeName
message:
Expected 360, but got $null.
stack-trace:
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\Enter-PSHostProcess.Tests.ps1: line 139
139: '@ -f $pipeName | pwsh -c - | Should -Be $pwsh.Id
3 tests in test/powershell failed
At D:\a\1\s\build.psm1:1371 char:13
+             throw "$($x.'test-results'.failures) tests in $TestArea f ...
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (3 tests in test/powershell failed:String) [], RuntimeException
    + FullyQualifiedErrorId : 3 tests in test/powershell failed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TylerLeonhardt
remote into this machine
e6e9259
iSazonov
Ilya (iSazonov) reviewed Feb 28, 2019
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Enter-PSHostProcess.Tests.ps1 Outdated

}
It "Can enter, exit, and re-enter another PSHost" {
# $pwsh = Start-PSProcess

@iSazonov Ilya (iSazonov) Feb 28, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why commented?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TylerLeonhardt TylerLeonhardt Feb 28, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably just hold off on reviewing. This issue only repros in CI... so it'll be a lot of trial and error.

When I remove WIP, you can review for real.

Open to suggestions on how to fix the tests though 😅

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Feb 28, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion was above - use "-file" parameter and put the temporary test script in file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
TylerLeonhardt and others added 5 commits February 28, 2019 21:42
@TylerLeonhardt
possible fix?
a710574
@TylerLeonhardt
check platform for better logs on *nix
9a491bc
@TylerLeonhardt
sleeps
36a0741
@TylerLeonhardt
wip: switch to jobs
77f80c3
@TylerLeonhardt
switch to all jobs
93d2a2b
@TylerLeonhardt

TylerLeonhardt commented Mar 1, 2019

Copy link
Copy Markdown
Member Author

If this succeeds CI, please restart a few times. I need 😴

If this works, I'll need to add a test to Startup.Tests.ps1 to test that pwsh -CustomPipeName foo actually works. And can move the last test into that as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TylerLeonhardt

TylerLeonhardt commented Mar 1, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

it... passed once so far. Triggered again with some comments... now time for bed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TylerLeonhardt
add a couple comments
ab37807
@iSazonov

Ilya (iSazonov) commented Mar 1, 2019

Copy link
Copy Markdown
Collaborator

I restarted CI-windows as you ask (previous was Ok).
TylerLeonhardt reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Mar 6, 2019
View reviewed changes
@TylerLeonhardt

TylerLeonhardt commented Mar 6, 2019

Copy link
Copy Markdown
Member Author

I spoke to Paul Higinbotham (@PaulHigin) about this and we agreed that since the tests have been reliable in this PR, we'll keep them in. If they become a problem again, we can remove the ones that use *-PSHostProcess
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TylerLeonhardt added 2 commits March 6, 2019 16:22
@TylerLeonhardt
address all feedback
af77dff
@TylerLeonhardt
Merge branch 'fix-enter-pshostprocess-tests' of github.com:TylerLeonh…
b5f298b 
…ardt/PowerShell into fix-enter-pshostprocess-tests
@iSazonov Ilya (iSazonov) assigned Aditya Patwardhan (adityapatwardhan) Mar 7, 2019
@iSazonov Ilya (iSazonov) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Mar 7, 2019
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Mar 7, 2019
View reviewed changes
Comment thread test/powershell/Host/ConsoleHost.Tests.ps1 Outdated
$pipePath = Get-PipePath $pipeName

# The pipePath should be created by the time the -Command is executed.
pwsh -CustomPipeName $pipeName -Command "Test-Path '$pipePath'" | Should -BeTrue

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Mar 7, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use $powershell instead. Using pwsh will call the installed pwsh on the system, not the one which we build.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TylerLeonhardt TylerLeonhardt Mar 7, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If what you say is true, then none of my CustomPipeName tests would be passing, right? I'm willing to change it though. Is that a magic variable or something?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vexx32 Rain Sallow (/u/ta11ow) (vexx32) Mar 7, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably set during the build or on test initialization with Start-PSPester, I'd imagine. 🙂

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TylerLeonhardt TylerLeonhardt Mar 7, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see what you're saying now :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TylerLeonhardt TylerLeonhardt Mar 7, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this so it's consistent

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/powershell/Host/ConsoleHost.Tests.ps1

"`$pid" | & $powershell -CustomPipeName $longPipeName -c -
# 64 is the ExitCode for BadCommandLineParameter
$LASTEXITCODE | Should -Be 64

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Mar 7, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check for FullyQualifiedErrorId that is not localized.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Enter-PSHostProcess.Tests.ps1 Outdated
Should -BeTrue -Because "The script was able to re-enter another process and grab the pid of '$powershellId'."

} finally {
$powershellJob | Stop-Process -Force -ErrorAction SilentlyContinue

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Mar 7, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Stop-Job | Remove-Job instead?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TylerLeonhardt TylerLeonhardt Mar 7, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're totally right. Added.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Enter-PSHostProcess.Tests.ps1
$ps.AddScript('$pid').Invoke() | Should -Be $pwsh.Id
$ps.AddScript('$pid').Invoke() | Should -Be $pwshId
} finally {
$rs.Dispose()

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Mar 7, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add $ps.Dispose()

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TylerLeonhardt TylerLeonhardt Mar 7, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TylerLeonhardt
address aditya's feedback
3e8f707
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Mar 7, 2019
View reviewed changes
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Mar 7, 2019

Copy link
Copy Markdown
Member

TylerLeonhardt - To fix the static analysis CI - update the link to https://www.itprotoday.com/powershell/powershell-basics-remote-management
TylerLeonhardt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Mar 7, 2019

Copy link
Copy Markdown
Member

Restarted Windows CI
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Mar 7, 2019

Copy link
Copy Markdown
Member

Travis Plunk (@TravisEz13) can you update your review?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TylerLeonhardt
TylerLeonhardt requested a review from Travis Plunk (TravisEz13) March 7, 2019 22:33
TylerLeonhardt added 3 commits March 7, 2019 14:38
@TylerLeonhardt
fixed two urls
009a76b
@TylerLeonhardt
Merge branch 'fix-enter-pshostprocess-tests' of github.com:TylerLeonh…
bc12333 
…ardt/PowerShell into fix-enter-pshostprocess-tests
@TylerLeonhardt
Merge branch 'master' into fix-enter-pshostprocess-tests
c9a3438
TravisEz13
Travis Plunk (TravisEz13) approved these changes Mar 7, 2019
View reviewed changes
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Mar 7, 2019

Copy link
Copy Markdown
Member

TylerLeonhardt Just realized the tests that were changed are tagged as Feature. Please push an empty commit with the commit message as [Feature] to execute those tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TylerLeonhardt added 3 commits March 7, 2019 16:06
@TylerLeonhardt
[feature] for CI
de0b604
@TylerLeonhardt
Merge branch 'fix-enter-pshostprocess-tests' of github.com:TylerLeonh…
54b8409 
…ardt/PowerShell into fix-enter-pshostprocess-tests
@TylerLeonhardt
[feature] for CI
d7c0d1c
@TylerLeonhardt

TylerLeonhardt commented Mar 8, 2019

Copy link
Copy Markdown
Member Author

triggered
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit a26d639 into PowerShell:master Mar 11, 2019
@TylerLeonhardt
TylerLeonhardt deleted the fix-enter-pshostprocess-tests branch March 11, 2019 18:15
@daxian-dbw Dongbo Wang (daxian-dbw) added this to the 6.2.0-GA-Consider milestone Mar 11, 2019
Travis Plunk (TravisEz13) added a commit that referenced this pull request Mar 21, 2019
@TravisEz13
Fix Enter-PSHostProcess tests flakiness (#9007)
e0d5dfd
@TravisEz13 Travis Plunk (TravisEz13) modified the milestones: 6.2.0-GA-Consider, 6.2.0 Mar 21, 2019
@TravisEz13

Travis Plunk (TravisEz13) commented Nov 22, 2019

Copy link
Copy Markdown
Member

This has become unreliable again. I have filed #11168
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TylerLeonhardt @adityapatwardhan
Fix Enter-PSHostProcess tests flakiness (PowerShell#9007)
eda99ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+3 more reviewers
@vexx32 Rain Sallow (/u/ta11ow) (vexx32) vexx32 left review comments
@RDIL Reece Dunham (RDIL) RDIL left review comments
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

6.2.0

Development

Successfully merging this pull request may close these issues.

Enter-PSHostProcess tests.By Process Id.Can enter using NamedPipeConnectionInfo is Failing 6% of the time

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@TylerLeonhardt @iSazonov @vexx32 @TravisEz13 @adityapatwardhan @PaulHigin @RDIL @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.