GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Translate Skipped the test results into something Azure DevOps does NOT understand by TravisEz13 · Pull Request #9124 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Mar 12, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Translate Skipped the test results into something Azure DevOps does NOT understand

PR Context

Make results reporting in Azure DevOps more obvious.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Translate the test results into something Azure DevOps Understands
ea958f8
@TravisEz13
Travis Plunk (TravisEz13) requested a review from Aditya Patwardhan (adityapatwardhan) March 12, 2019 01:13
Travis Plunk (TravisEz13) added 3 commits March 11, 2019 18:28
@TravisEz13
Use existing file name for temp file so that artifact names are meani…
1c35b4f 
…ngful
@TravisEz13
Try a translation based on the NUnit spec
5214930
@TravisEz13
make sure that pending issues get reported
670a7ab
iSazonov
Ilya (iSazonov) reviewed Mar 12, 2019
View reviewed changes
Comment thread build.psm1 Outdated
$fileName = Split-Path -Leaf -Path $Path
$tempFilePath = Join-Path ([system.io.path]::GetTempPath()) -ChildPath $fileName

# Althought NUnit allowed values are: Passed, Failed, Inconclusive or Ignored (the spec says Skipped but it doesn' work with Azure DevOps)

@iSazonov Ilya (iSazonov) Mar 12, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "pending"?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Mar 12, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending is reported by pested as Inconclusive and is ignored by Azure DevOps.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
RDIL
Reece Dunham (RDIL) reviewed Mar 12, 2019
View reviewed changes
Comment thread build.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Mar 12, 2019
View reviewed changes
@TravisEz13
map ignored to skipped so azure dev ops ignored for the results.
6bfb2d1
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the convert_pester_results_to_azureDevOps_status branch from 3628b75 to 6bfb2d1 Compare March 12, 2019 18:34
@TravisEz13 Travis Plunk (TravisEz13) changed the title Translate the test results into something Azure DevOps understands Translate Skipped the test results into something Azure DevOps does NOT understand Mar 12, 2019
Travis Plunk (TravisEz13) and others added 2 commits March 12, 2019 11:37
@TravisEz13
upload original xml
6b0769b
@RDIL @TravisEz13
Fix typo
9fffc0d 
Co-Authored-By: TravisEz13 <[email protected]>
RDIL
Reece Dunham (RDIL) approved these changes Mar 12, 2019
View reviewed changes

@RDIL Reece Dunham (RDIL) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Travis Plunk (TravisEz13) marked this pull request as ready for review March 20, 2019 20:21
@TravisEz13
Travis Plunk (TravisEz13) requested review from Paul Higinbotham (PaulHigin), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners March 20, 2019 20:21
@TravisEz13 Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 20, 2019
@TravisEz13
Travis Plunk (TravisEz13) merged commit b632b60 into PowerShell:master Mar 20, 2019
@TravisEz13
Travis Plunk (TravisEz13) deleted the convert_pester_results_to_azureDevOps_status branch March 20, 2019 20:27
Travis Plunk (TravisEz13) added a commit that referenced this pull request Mar 21, 2019
@TravisEz13
Translate Skipped the test results into something Azure DevOps does N…
8f9666f 
…OT understand (#9124)
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Apr 3, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Translate Skipped the test results into something Azure DevOps does N…
56cb71f 
…OT understand (PowerShell#9124)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
+1 more reviewer
@RDIL Reece Dunham (RDIL) RDIL approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@TravisEz13 @adityapatwardhan @iSazonov @RDIL
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.