GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Disable Homebrew analytics in macOS VSTS builds by RDIL · Pull Request #9130 · PowerShell/PowerShell

Conversation

@RDIL

@RDIL Reece Dunham (RDIL) commented Mar 13, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Since these are just test installs they should not count towards the totals in the formulae analytic center.

PR Context

  • this will save about 15-20 seconds but all time counts

By default this is on but it shouldn't be

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RDIL
Disable Homebrew analytics in macOS VSTS builds
04cb2d1
@RDIL
Reece Dunham (RDIL) requested review from Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners March 13, 2019 14:31
iSazonov
Ilya (iSazonov) approved these changes Mar 13, 2019
View reviewed changes
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Mar 13, 2019
@TravisEz13

Travis Plunk (TravisEz13) commented Mar 13, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Can you make a similar change in the following location:

https://github.com/PowerShell/PowerShell/blob/master/tools/releaseBuild/azureDevOps/templates/mac.yml

You'll have to add the variables statement between lines 5 and 9
RDIL reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Mar 13, 2019

Copy link
Copy Markdown
Contributor Author

On it
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
--replace-all added 3 commits March 13, 2019 17:11
--replace-all
add to releaseBuild macOS config
58d156b
--replace-all
Rebase from 'upstream/master'
304b614
--replace-all
Force-push branch
5a66bea
@RDIL

Reece Dunham (RDIL) commented Mar 13, 2019

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) fixed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Reece Dunham (RDIL) added 2 commits March 14, 2019 10:38
@RDIL
empty commit for codefactor
8ab8c6e 
codefactor is spamming my email and so this empty push is to disable it
@RDIL
[feature] rerun windows CI (failure unrelated)
4820f99
@RDIL

Reece Dunham (RDIL) commented Mar 15, 2019

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) Ilya (@iSazonov) please re review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Mar 16, 2019
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) approved these changes Mar 16, 2019
View reviewed changes
@TravisEz13 Travis Plunk (TravisEz13) added this to the 6.2.0-GA-Consider milestone Mar 16, 2019
@TravisEz13 Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 16, 2019
@TravisEz13
Travis Plunk (TravisEz13) merged commit eac3101 into PowerShell:master Mar 16, 2019
@RDIL
Reece Dunham (RDIL) deleted the patch-3 branch March 16, 2019 18:58
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Mar 21, 2019
@RDIL @TravisEz13
Disable Homebrew analytics in macOS VSTS builds (#9130)
3bf36c1
@TravisEz13 Travis Plunk (TravisEz13) modified the milestones: 6.2.0-GA-Consider, 6.2.0 Mar 21, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@RDIL @TravisEz13
Disable Homebrew analytics in macOS VSTS builds (PowerShell#9130)
7a2dcd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

6.2.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@RDIL @TravisEz13 @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.