GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Publish global tool packages to pwshtool blob and bug fixes by adityapatwardhan · Pull Request #9163 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Mar 18, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #9148

PR Summary

Publish global tool packages to a difference storage account. Also fix issues in removing unnecessary runtimes. Also added debug statements.

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan
Publish global tool packages to pwshtool blob
a1a461b
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners March 18, 2019 22:39
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added this to the 6.2.0-GA-Consider milestone Mar 18, 2019
@adityapatwardhan
Fix issue in cleanup logic where Linux assemblies will always be cleaned
3e3653f
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Mar 19, 2019

Copy link
Copy Markdown
Member Author

Travis Plunk (@TravisEz13) The PR is ready for review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 19, 2019
TravisEz13
Travis Plunk (TravisEz13) requested changes Mar 19, 2019
View reviewed changes
Comment thread tools/packaging/packaging.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Rename IsWindows switch to KeepWindowsRuntimes
1b83da9
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Mar 19, 2019

Copy link
Copy Markdown
Member Author

Travis Plunk (@TravisEz13) - Addressed your comments. Please re-review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Mar 19, 2019
View reviewed changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title Publish global tool packages to pwshtool blob and bug fixes WIIP - Publish global tool packages to pwshtool blob and bug fixes Mar 19, 2019
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Mar 19, 2019

Copy link
Copy Markdown
Member Author

Do not merge. More changes coming.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Create RID specific packages
1636ad5
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title WIIP - Publish global tool packages to pwshtool blob and bug fixes WIP - Publish global tool packages to pwshtool blob and bug fixes Mar 19, 2019
@adityapatwardhan
Fix package type name
086e54d
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Mar 20, 2019
View reviewed changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title WIP - Publish global tool packages to pwshtool blob and bug fixes Publish global tool packages to pwshtool blob and bug fixes Mar 20, 2019
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Travis Plunk (TravisEz13) March 20, 2019 18:50
TravisEz13
Travis Plunk (TravisEz13) approved these changes Mar 20, 2019
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 753d318 into PowerShell:master Mar 20, 2019
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the FixGlobalToolPackage branch March 20, 2019 20:44
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Mar 21, 2019
@adityapatwardhan @TravisEz13
Publish global tool packages to pwshtool blob and bug fixes (#9163)
1b1ae6d
@TravisEz13 Travis Plunk (TravisEz13) modified the milestones: 6.2.0-GA-Consider, 6.2.0 Mar 21, 2019
@iSazonov Ilya (iSazonov) assigned Aditya Patwardhan (adityapatwardhan) Apr 3, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Publish global tool packages to pwshtool blob and bug fixes (PowerS…
8b5fa15 
…hell#9163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

6.2.0

Development

Successfully merging this pull request may close these issues.

PowerShell.Linux and PowerShell.Windows nuget package contain extra runtimes

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@adityapatwardhan @TravisEz13 @PaulHigin @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.