GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Obsolete message to Send-MailMessage by TravisEz13 · Pull Request #9178 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Mar 20, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Add Obsolete message to Send-MailMessage

PR Context

See PowerShell/PowerShell-RFC#160

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Add Obsolete message to Send-MailMessage
a29e1ac
iSazonov
Ilya (iSazonov) reviewed Mar 21, 2019
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Send-MailMessage.cs Outdated
/// <summary>
/// Implementation for the Send-MailMessage command.
/// </summary>
[Obsolete("This cmdlet only supports sending mail from insecure SMTP servers. While there is no immediate replacement available in PowerShell, we recommend you do not use Send-MailMessage at this time.")]

@iSazonov Ilya (iSazonov) Mar 21, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"from"? Maybe "insecure connect to"?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Mar 21, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pinged Joey Aiello (@joeyaiello) who wrote the message

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Travis Plunk (TravisEz13) marked this pull request as ready for review March 21, 2019 18:55
@TravisEz13
Travis Plunk (TravisEz13) requested review from James Truher (JamesWTruher) and Paul Higinbotham (PaulHigin) as code owners March 21, 2019 18:55
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Mar 21, 2019
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Send-MailMessage.cs Outdated
/// <summary>
/// Implementation for the Send-MailMessage command.
/// </summary>
[Obsolete("This cmdlet only supports sending mail from insecure SMTP servers. While there is no immediate replacement available in PowerShell, we recommend you do not use Send-MailMessage at this time.")]

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Mar 21, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test to validate.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Mar 21, 2019

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WarningVariables does not capture this warning.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Mar 22, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try using powershell.invoke and then check the streams.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Mar 22, 2019

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a xUnit test suite for all public APIs to have API contract.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Mar 21, 2019
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Send-MailMessage.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
try to test for warnings
3b4e3f8
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Mar 22, 2019
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Send-MailMessage.Tests.ps1 Outdated

$null = $powershell.AddCommand("Send-MailMessage").AddParameters($InputObject).AddParameter("ErrorAction","SilentlyContinue")

#Send-MailMessage @InputObject -ErrorAction SilentlyContinue

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Mar 22, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Travis Plunk (TravisEz13) and others added 2 commits March 22, 2019 10:18
@TravisEz13
Address PR Feedback
79547f8
@SteveL-MSFT @TravisEz13
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Sen…
ecdeea9 
…d-MailMessage.cs

Co-Authored-By: TravisEz13 <[email protected]>
iSazonov
Ilya (iSazonov) approved these changes Mar 22, 2019
View reviewed changes
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Mar 22, 2019
View reviewed changes
Travis Plunk (TravisEz13) added 2 commits March 22, 2019 11:50
@TravisEz13
Update Send-MailMessage.cs
f5cbd7b
@TravisEz13
Update Send-MailMessage.cs
cc0f1e0
iSazonov
Ilya (iSazonov) reviewed Mar 22, 2019
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/Send-MailMessage.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov @TravisEz13
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Sen…
6ac7c6d 
…d-MailMessage.cs

Co-Authored-By: TravisEz13 <[email protected]>
@TravisEz13
Travis Plunk (TravisEz13) requested a review from Steve Lee (SteveL-MSFT) March 22, 2019 19:05
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Mar 22, 2019
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 94616f1 into PowerShell:master Mar 22, 2019
@TravisEz13
Travis Plunk (TravisEz13) deleted the marke_send_mailmessage_obsolete branch March 22, 2019 19:52
@TravisEz13 Travis Plunk (TravisEz13) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 22, 2019
@TravisEz13 Travis Plunk (TravisEz13) added this to the 6.2.0-GA-Consider milestone Mar 22, 2019
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Mar 23, 2019
Travis Plunk (TravisEz13) added a commit that referenced this pull request Mar 25, 2019
@TravisEz13 @SteveL-MSFT @iSazonov
Add Obsolete message to Send-MailMessage (#9178)
f581ea6 
Add Obsolete message to Send-MailMessage

## PR Context

See PowerShell/PowerShell-RFC#160

Co-authored-by: Steve Lee <[email protected]>
Co-authored-by: Ilya <[email protected]>
# Conflicts:
#	test/powershell/Modules/Microsoft.PowerShell.Utility/Send-MailMessage.Tests.ps1
@TravisEz13 Travis Plunk (TravisEz13) modified the milestones: 6.2.0-GA-Consider, 6.2.0 Mar 25, 2019
@ThreeFive-O ThreeFive-O mentioned this pull request Jul 29, 2019
Rework Send-MailMessage cmdlet with MailKit #10246
Closed
5 of 14 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13 @SteveL-MSFT @iSazonov
Add Obsolete message to Send-MailMessage (PowerShell#9178)
4868270 
Add Obsolete message to Send-MailMessage

## PR Context

See PowerShell/PowerShell-RFC#160

Co-authored-by: Steve Lee <[email protected]>
Co-authored-by: Ilya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

6.2.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@TravisEz13 @daxian-dbw @SteveL-MSFT @adityapatwardhan @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.