GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add psremoting enable/disable cmdlet warning messages by PaulHigin · Pull Request #9203 · PowerShell/PowerShell

Conversation

@PaulHigin

@PaulHigin Paul Higinbotham (PaulHigin) commented Mar 22, 2019

Copy link
Copy Markdown
Contributor

PR Summary

Adds warning messages to the Enable-PSRemoting and Disable-PSRemoting cmdlets that informs the user that the cmdlets only affect PSCore6 remoting endpoint configurations and not Windows PowerShell configurations.

PR Context

As documented, Enable-PSRemoting and Disable-PSRemoting affects all PowerShell remoting on a Windows system, and Windows users will likely expect the cmdlets to continue working this way in PSCore6. However, these cmdlets currently affect only PSCore6 remoting endpoints when run in PSCore6 and have no effect on Windows remoting endpoints.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: 8469
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Paul Higinbotham (PaulHigin) added 9 commits February 19, 2019 13:39
@PaulHigin
address merge conflict in test file
7db6b7b
@PaulHigin
Merge branch 'master' of https://github.com/PaulHigin/powershell
c7351d0
@PaulHigin
Merge remote-tracking branch 'upstream/master'
d049ff5
@PaulHigin
Merge remote-tracking branch 'upstream/master'
d6711a5
@PaulHigin
Merge branch 'master' of https://github.com/PaulHigin/PowerShell
3862133
@PaulHigin
Merge remote-tracking branch 'upstream/master'
350a24c
@PaulHigin
Merge branch 'master' of https://github.com/PaulHigin/powershell
bb62b1a
@PaulHigin
Merge remote-tracking branch 'upstream/master'
dfcddce
@PaulHigin
Add warningmessages to Enable-PSRemoting and Disable-PSRemoting cmdlets
0da7ed2
@PaulHigin Paul Higinbotham (PaulHigin) assigned Aditya Patwardhan (adityapatwardhan) Mar 22, 2019
@PaulHigin
Paul Higinbotham (PaulHigin) requested review from Steve Lee (SteveL-MSFT) and Travis Plunk (TravisEz13) March 22, 2019 19:15
@PaulHigin
Paul Higinbotham (PaulHigin) requested a review from Mike Richmond (mirichmo) as a code owner March 22, 2019 19:15
@PaulHigin
Paul Higinbotham (PaulHigin) removed the request for review from Mike Richmond (mirichmo) March 22, 2019 19:16
@PaulHigin Paul Higinbotham (PaulHigin) added this to the 6.2.0-GA-Consider milestone Mar 22, 2019
@PaulHigin Paul Higinbotham (PaulHigin) added the OS-Windows label Mar 22, 2019
TravisEz13
Travis Plunk (TravisEz13) requested changes Mar 22, 2019
View reviewed changes
Comment thread src/System.Management.Automation/resources/RemotingErrorIdStrings.resx Outdated
<data name="PSCoreRemotingEnableWarning" xml:space="preserve">
<value>PowerShell remoting has been enabled only for PowerShell Core configurations and does not affect Windows PowerShell remoting configurations. Run this cmdlet in Windows PowerShell to affect all PowerShell remoting configurations.</value>
</data>
</root> No newline at end of file

@TravisEz13 Travis Plunk (TravisEz13) Mar 22, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline at end of file

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@PaulHigin Paul Higinbotham (PaulHigin) Mar 22, 2019

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intended. No newline is needed in this case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/resources/RemotingErrorIdStrings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.
@PaulHigin
Restore schema to https
b30bb8b
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Mar 22, 2019
View reviewed changes
Comment thread src/System.Management.Automation/resources/RemotingErrorIdStrings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/resources/RemotingErrorIdStrings.resx Resolved

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) reviewed Mar 22, 2019
View reviewed changes
Comment thread src/System.Management.Automation/resources/RemotingErrorIdStrings.resx Outdated
: and then encoded with base64 encoding.
-->
<xsd:schema id="root" xmlns="" xmlns:xsd="https://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
<xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">

@TravisEz13 Travis Plunk (TravisEz13) Mar 22, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
<xsd:schema id="root" xmlns="" xmlns:xsd="https://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@PaulHigin
Changing http back to https, added back missing linefeed at end of file
5b11e1a
TravisEz13
Travis Plunk (TravisEz13) approved these changes Mar 22, 2019
View reviewed changes
@PaulHigin

Paul Higinbotham (PaulHigin) commented Mar 25, 2019

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) Can this be merged? Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) merged commit 9ea6058 into PowerShell:master Mar 25, 2019
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Mar 25, 2019
@PaulHigin @TravisEz13
Add psremoting enable/disable cmdlet warning messages (#9203)
fc87a3b 
Adds warning messages to the Enable-PSRemoting and Disable-PSRemoting cmdlets that informs the user that the cmdlets only affect PSCore6 remoting endpoint configurations and not Windows PowerShell configurations.

PR Context
As documented, Enable-PSRemoting and Disable-PSRemoting affects all PowerShell remoting on a Windows system, and Windows users will likely expect the cmdlets to continue working this way in PSCore6. However, these cmdlets currently affect only PSCore6 remoting endpoints when run in PSCore6 and have no effect on Windows remoting endpoints.
@TravisEz13 Travis Plunk (TravisEz13) modified the milestones: 6.2.0-GA-Consider, 6.2.0 Mar 25, 2019
@TravisEz13 Travis Plunk (TravisEz13) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Mar 26, 2019
@PaulHigin
Paul Higinbotham (PaulHigin) deleted the add-psremoting-warning branch July 17, 2019 23:01
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@PaulHigin @TravisEz13
Add psremoting enable/disable cmdlet warning messages (PowerShell#9203)
574459e 
Adds warning messages to the Enable-PSRemoting and Disable-PSRemoting cmdlets that informs the user that the cmdlets only affect PSCore6 remoting endpoint configurations and not Windows PowerShell configurations.

PR Context
As documented, Enable-PSRemoting and Disable-PSRemoting affects all PowerShell remoting on a Windows system, and Windows users will likely expect the cmdlets to continue working this way in PSCore6. However, these cmdlets currently affect only PSCore6 remoting endpoints when run in PSCore6 and have no effect on Windows remoting endpoints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log OS-Windows

Projects

None yet

Milestone

6.2.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@PaulHigin @TravisEz13 @SteveL-MSFT @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.