GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Typo in new parameter set by TylerLeonhardt · Pull Request #9205 · PowerShell/PowerShell

Conversation

@TylerLeonhardt

@TylerLeonhardt TylerLeonhardt commented Mar 22, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Realized there was a typo in my parameter set name...

Originally added in #8889

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: Doc new -CustomPipeName parameter on pwsh and Enter-PSHostProcess MicrosoftDocs/PowerShell-Docs#3755
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] to your commit messages if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TylerLeonhardt
[feature]Typo in new parameter set
12bb296
@TylerLeonhardt
TylerLeonhardt requested review from Paul Higinbotham (PaulHigin) and Mike Richmond (mirichmo) as code owners March 22, 2019 19:53
@TylerLeonhardt
TylerLeonhardt requested a review from Steve Lee (SteveL-MSFT) March 22, 2019 20:04
@TylerLeonhardt TylerLeonhardt changed the title [feature] Typo in new parameter set Typo in new parameter set Mar 22, 2019
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Mar 23, 2019
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Mar 23, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

TylerLeonhardt Please add a reference to PR where we made the typo.

Also can we cover this by tests?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) self-assigned this Mar 23, 2019
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Mar 23, 2019
@TylerLeonhardt

TylerLeonhardt commented Mar 23, 2019

Copy link
Copy Markdown
Member Author

Updated the PR description.

I don't think we really need a test to make sure the parametersets are spelled correctly. I don't think that's something we've done much in the past.

I found the typo while I was working on the docs for the original feature and working on the docs offered a good opportunity to double check parametersets and other things are spelled correctly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Mar 23, 2019

Copy link
Copy Markdown
Collaborator

TylerLeonhardt Thanks for fixing the typo. I'll merge on next week.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Mar 23, 2019

Copy link
Copy Markdown
Collaborator

I wonder that 4 reviewers (I too) skipped this in previous PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Mar 24, 2019
View reviewed changes
@iSazonov Ilya (iSazonov) added this to the 6.3.0-preview.1 milestone Mar 25, 2019
@iSazonov
Ilya (iSazonov) merged commit cd7d779 into PowerShell:master Mar 25, 2019
@TylerLeonhardt
TylerLeonhardt deleted the typo-in-new-parameter-set branch March 25, 2019 22:12
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TylerLeonhardt @iSazonov
Typo in new parameter set (PowerShell#9205)
e7e53f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@mirichmo Mike Richmond (mirichmo) Awaiting requested review from mirichmo
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@TylerLeonhardt @iSazonov @daxian-dbw @SteveL-MSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.