GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove code from `CI.psm1` to optionally run Feature tests by RDIL · Pull Request #9212 · PowerShell/PowerShell

Conversation

@RDIL

@RDIL Reece Dunham (RDIL) commented Mar 23, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Makes feature tests run without the tag (which now causes issues)

PR Context

Travis Plunk (@TravisEz13) said this needed to be done

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Reece Dunham (RDIL) added 4 commits March 23, 2019 14:18
@RDIL
(WIP) remove feature tests
fbb0e54
@RDIL
Update CONTRIBUTING.md
b4a5bb8
@RDIL
Update testing-guidelines.md
042dcf4
@RDIL
Update PULL_REQUEST_TEMPLATE.md
cd9dde3
@RDIL Reece Dunham (RDIL) changed the title (WIP) remove feature tests Remove feature tests Mar 23, 2019
TravisEz13
Travis Plunk (TravisEz13) reviewed Mar 23, 2019
View reviewed changes
Comment thread tools/ci.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RDIL
Reece Dunham (RDIL) marked this pull request as ready for review March 24, 2019 01:34
@RDIL
Reece Dunham (RDIL) requested review from Paul Higinbotham (PaulHigin), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga), Dongbo Wang (daxian-dbw) and Joey Aiello (joeyaiello) as code owners March 24, 2019 01:34
iSazonov
Ilya (iSazonov) reviewed Mar 24, 2019
View reviewed changes
Comment thread .github/CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 24, 2019
Reece Dunham (RDIL) added 3 commits March 24, 2019 14:16
@RDIL
Revert VS Code => VSCode change
6c9e5d9
@RDIL
cleanup
e20a8d9
@RDIL
rebase
39739db
@RDIL

Reece Dunham (RDIL) commented Mar 26, 2019

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) anything specific you need me to do right now?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Reece Dunham (RDIL) and others added 5 commits March 26, 2019 10:55
@RDIL
Run daily build if conditions are met
c83d35d
@RDIL
Update logic :(
baf4a5f
@RDIL
Merge pull request #13 from PowerShell/master
761d693 
Rebase
@TravisEz13
always produce windows arm packages
dc2db00
@TravisEz13
always throw on failure
b6698d2
@TravisEz13

Travis Plunk (TravisEz13) commented Mar 26, 2019

Copy link
Copy Markdown
Member

Reece Dunham (@RDIL) ... I reviewed the usage of test-dailybuild and corrected the logic.
RDIL reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Mar 26, 2019

Copy link
Copy Markdown
Contributor Author

Thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Mar 26, 2019
Linux CI build does not fail when Pester Tag is missing #9193
Closed
@TravisEz13 Travis Plunk (TravisEz13) added this to the 6.3.0-preview.1 milestone Mar 26, 2019
TravisEz13
Travis Plunk (TravisEz13) approved these changes Mar 26, 2019
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) requested changes Mar 26, 2019
View reviewed changes
Comment thread docs/testing-guidelines/testing-guidelines.md
One of the following tags must be used:

* `CI` - this tag indicates that the tests in the `Describe` block will be executed as part of the CI/PR process
* `Feature` - tests with this tag will not be executed as part of the CI/PR process, but they will be executed on a daily basis as part of a `cron` driven build.

@TravisEz13 Travis Plunk (TravisEz13) Mar 26, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this should not be deleteed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RDIL
Address feedback
555efce
TravisEz13
Travis Plunk (TravisEz13) reviewed Mar 26, 2019
View reviewed changes
Comment thread docs/testing-guidelines/testing-guidelines.md

* `CI` - this tag indicates that the tests in the `Describe` block will be executed as part of the CI/PR process
* `Feature` - tests with this tag will not be executed as part of the CI/PR process, but they will be executed on a daily basis as part of a `cron` driven build.
They indicate that the test will be validating more behavior, or will be using remote network resources (ex: package management tests)

@TravisEz13 Travis Plunk (TravisEz13) Mar 26, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still be a sub-bullet under feature

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ThreeFive-O

ThreeFive-O commented Mar 27, 2019

Copy link
Copy Markdown
Contributor

Reece Dunham (@RDIL): Could you please update the PR title and give more details in the summary and context. Right now it could be interpreted that all Pester tests tagged with Feature will be removed, which is certainly not the case.
This PR rather only targets the [feature] tag in commit messages, which were necessary to include Pester tests marked with Feature.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Mar 27, 2019

Copy link
Copy Markdown
Contributor Author

Sure
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Update testing-guidelines.md
cc0f626
TravisEz13
Travis Plunk (TravisEz13) approved these changes Mar 27, 2019
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Mar 27, 2019

Copy link
Copy Markdown
Member

PoshChan-Bot (@PoshChan) Please remind me in 1 hour
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@PoshChan

PoshChan-Bot (PoshChan) commented Mar 27, 2019

Copy link
Copy Markdown
Collaborator

Travis Plunk (@TravisEz13), all requests start with the magic word Please.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Mar 27, 2019

Copy link
Copy Markdown
Contributor Author

PoshChan-Bot (@PoshChan) please remind me in 1 hour
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@PoshChan

PoshChan-Bot (PoshChan) commented Mar 27, 2019

Copy link
Copy Markdown
Collaborator

Reece Dunham (@RDIL), I do not understand: please remind me in an hour
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@PoshChan

PoshChan-Bot (PoshChan) commented Mar 27, 2019

Copy link
Copy Markdown
Collaborator

Reece Dunham (@RDIL), will remind you in 1 hour
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) changed the title Remove feature tests Remove Code from CI.ps1 to optionally run Feature tests Mar 27, 2019
@TravisEz13 Travis Plunk (TravisEz13) changed the title Remove Code from CI.ps1 to optionally run Feature tests Remove code from CI.psm1 to optionally run Feature tests Mar 27, 2019
@PoshChan

PoshChan-Bot (PoshChan) commented Mar 27, 2019

Copy link
Copy Markdown
Collaborator

Reece Dunham (@RDIL), this is the reminder you requested 1 hour ago
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RDIL

Reece Dunham (RDIL) commented Mar 27, 2019

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) this is the reminder you requested an hour ago
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) merged commit 1227614 into PowerShell:master Mar 27, 2019
@RDIL
Reece Dunham (RDIL) deleted the patch-6 branch March 27, 2019 20:39
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Apr 3, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@RDIL @TravisEz13
Remove code from CI.psm1 to optionally run Feature tests (PowerShel…
d2c2f7d 
…l#9212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@joeyaiello Joey Aiello (joeyaiello) Awaiting requested review from joeyaiello
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
+1 more reviewer
@vexx32 Rain Sallow (/u/ta11ow) (vexx32) vexx32 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@RDIL @TravisEz13 @ThreeFive-O @PoshChan @iSazonov @vexx32
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.