GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Ensure Wait-UntilTrue returns $true in Pester tests by xtqqczze · Pull Request #9458 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Apr 24, 2019

Copy link
Copy Markdown
Contributor

PR Summary

  • Ensure Wait-UntilTrue returns $true
  • Ensure Wait-FileToBePresent returns $true
  • Mark a ConvertTo-Json test as Pending due to test failure

PR Context

Pester tests should check if the function Wait-UntilTrue actually returns $true rather than timing out.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
  • Testing - New and feature
    • Make sure you've added a new test if existing tests do not effectively test the code changed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
xtqqczze added 2 commits April 24, 2019 23:04
@xtqqczze
Ensure Wait-UntilTrue returns $true in Pester tests
b319752 
* Ensure Wait-UntilTrue returns $true in Pester tests
* Mark a ConvertTo-Json test as Pendingc due to test failure
@xtqqczze
[Feature] Empty commit for CI
cf09413
@xtqqczze
xtqqczze requested review from Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners April 24, 2019 22:10
@xtqqczze xtqqczze mentioned this pull request Apr 24, 2019
Fix ConvertTo-Json test #8645
Closed
8 of 11 tasks
@xtqqczze

xtqqczze commented Apr 24, 2019

Copy link
Copy Markdown
Contributor Author

Test failure on PowerShell-CI-linux appears to be unrelated to this PR, probably caused by #9250.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) reviewed Apr 25, 2019
View reviewed changes
Comment thread test/powershell/Language/Scripting/Debugging/Debugging.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Apr 25, 2019
@iSazonov Ilya (iSazonov) added this to the 7.0.0-preview.1 milestone Apr 25, 2019
@xtqqczze
Revert change as requested
bb5de93 
Use `Should -BeTrue` instead of `Should -BeExactly $true`.
iSazonov
Ilya (iSazonov) reviewed Apr 26, 2019
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Json.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/tools/Modules/HelpersCommon/HelpersCommon.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
xtqqczze added 2 commits April 26, 2019 17:47
@xtqqczze
Explicit return
4e7fbc2
@xtqqczze
Ensure Start-Sleep doesn't produce any output
e95e3ab
TravisEz13
Travis Plunk (TravisEz13) reviewed Apr 26, 2019
View reviewed changes
Comment thread test/tools/Modules/HelpersCommon/HelpersCommon.psm1
}
# Wait
Start-Sleep -Milliseconds $intervalInMilliseconds
Start-Sleep -Milliseconds $intervalInMilliseconds > $null

@TravisEz13 Travis Plunk (TravisEz13) Apr 26, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed, but won't hurt anything

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
iSazonov
Ilya (iSazonov) approved these changes Apr 26, 2019
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one request to open a tracking issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov Ilya (iSazonov) assigned Aditya Patwardhan (adityapatwardhan) Apr 26, 2019
@xtqqczze

xtqqczze commented Apr 27, 2019

Copy link
Copy Markdown
Contributor Author

Opened #9489 for ConvertTo-Json test failure.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes May 2, 2019
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit a702f68 into PowerShell:master May 2, 2019
@xtqqczze
xtqqczze deleted the WaitUntilTrue-ShouldBeTrue branch May 8, 2019 19:50
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze @adityapatwardhan
Ensure Wait-UntilTrue returns $true in Pester tests (PowerShell#9458)
37f2272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 left review comments
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@xtqqczze @TravisEz13 @adityapatwardhan @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.